Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2642823006: Move MediaMetadata timer to frame-specific TaskRunnerTimer. (Closed)

Created:
3 years, 11 months ago by Byoungkwon Ko
Modified:
3 years, 11 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move MediaMetadata timer to frame-specific TaskRunnerTimer. Move MediaMetadata timer m_notifySessionTimer to frame-specific TaskRunnerTimer. This associates it with the frame's MiscPlatformAPI timer task queue. The spec does not explicitly specify what task source it should use.[1] [1] The spec link: https://wicg.github.io/mediasession/#the-mediametadata-interface This CL is migrating tasks/timers from a per-renderer scheduler to a per-frame scheduler: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/80dsbEEOcWY BUG=624694 Review-Url: https://codereview.chromium.org/2642823006 Cr-Commit-Position: refs/heads/master@{#446006} Committed: https://chromium.googlesource.com/chromium/src/+/25c3eba7f5229bf15b15cea62165fcc5e5dbb6e0

Patch Set 1 #

Patch Set 2 : Move MediaMetadata timer to frame-specific TaskRunnerTimer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/mediasession/MediaMetadata.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaMetadata.cpp View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 22 (15 generated)
Byoungkwon Ko
PTAL
3 years, 11 months ago (2017-01-19 19:26:51 UTC) #5
haraken
The spec does not explicitly specify what task source it should use. https://wicg.github.io/mediasession/#the-mediametadata-interface Shall we ...
3 years, 11 months ago (2017-01-20 05:10:00 UTC) #8
Byoungkwon Ko
As you told, the spec does not explicitly specify what task source it should use. ...
3 years, 11 months ago (2017-01-20 22:20:08 UTC) #9
haraken
LGTM +mlamouri FYI
3 years, 11 months ago (2017-01-21 01:34:01 UTC) #16
mlamouri (slow - plz ping)
lgtm I filed https://github.com/WICG/mediasession/issues/182
3 years, 11 months ago (2017-01-25 05:36:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642823006/20001
3 years, 11 months ago (2017-01-25 11:36:36 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 12:58:01 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/25c3eba7f5229bf15b15cea62165...

Powered by Google App Engine
This is Rietveld 408576698