Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp

Issue 2642823005: Phase II Step 1: Remove updateImage() reentrancy around decodeError() (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/loader/resource/ImageResourceInfo.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
diff --git a/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp b/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
index a6f8ca3e000ad9e47ffd8792173625fb826e3bf0..1dc23a7c0bd38cdafce8c995694a53ad77ea53ea 100644
--- a/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
+++ b/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
@@ -907,7 +907,7 @@ TEST(ImageResourceTest, CancelOnDecodeError) {
EXPECT_TRUE(observer->imageNotifyFinishedCalled());
EXPECT_EQ(ResourceStatus::DecodeError,
observer->statusOnImageNotifyFinished());
- EXPECT_EQ(2, observer->imageChangedCount());
+ EXPECT_EQ(1, observer->imageChangedCount());
EXPECT_FALSE(imageResource->isLoading());
}
@@ -1162,7 +1162,7 @@ TEST(ImageResourceTest, FetchAllowPlaceholderUnsuccessful) {
// The dimensions could not be extracted, so the full original image should be
// loading.
EXPECT_FALSE(observer->imageNotifyFinishedCalled());
- EXPECT_EQ(3, observer->imageChangedCount());
+ EXPECT_EQ(2, observer->imageChangedCount());
testThatReloadIsStartedThenServeReload(
testURL, imageResource, imageResource->getContent(), observer.get(),
« no previous file with comments | « third_party/WebKit/Source/core/loader/resource/ImageResourceInfo.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698