third_party/WebKit/Source/core/loader/resource/ImageResourceInfo.h - Issue 2642823005: Phase II Step 1: Remove updateImage() reentrancy around decodeError()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/resource/ImageResourceInfo.h

Issue 2642823005: Phase II Step 1: Remove updateImage() reentrancy around decodeError() (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/resource/ImageResourceInfo.h

diff --git a/third_party/WebKit/Source/core/loader/resource/ImageResourceInfo.h b/third_party/WebKit/Source/core/loader/resource/ImageResourceInfo.h

index e78dbb505981e42ed0085c74a18801972038e050..239c4f3fc97b17e782f9b75d431a2268ae21a7bf 100644

--- a/third_party/WebKit/Source/core/loader/resource/ImageResourceInfo.h

+++ b/third_party/WebKit/Source/core/loader/resource/ImageResourceInfo.h

@@ -46,10 +46,6 @@ class CORE_EXPORT ImageResourceInfo : public GarbageCollectedMixin {

virtual bool hasCacheControlNoStoreHeader() const = 0;

virtual const ResourceError& resourceError() const = 0;

- // Like Resource::error(), decodeError() makes corresponding ImageResource

- // (if any) DecodeError and finishes loading.

- virtual void decodeError(bool allDataReceived) = 0;

// TODO(hiroshige): Remove this.

virtual void setIsPlaceholder(bool) = 0;