Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1260)

Issue 2642823003: Small optimization of ChooseOldestImmediateOrDelayedTaskWithPriority (Closed)

Created:
3 years, 11 months ago by alex clarke (OOO till 29th)
Modified:
3 years, 11 months ago
Reviewers:
Sami
CC:
chromium-reviews, blink-reviews, kinuko+watch, scheduler-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Small optimization of ChooseOldestImmediateOrDelayedTaskWithPriority An optimization split out from https://codereview.chromium.org/2546423002/ Also adds a few sanity checks. BUG=578176 Review-Url: https://codereview.chromium.org/2642823003 Cr-Commit-Position: refs/heads/master@{#444491} Committed: https://chromium.googlesource.com/chromium/src/+/04142ad87c05fdebba5b231f274e8aaec9abdf91

Patch Set 1 #

Patch Set 2 : Add a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -12 lines) Patch
M third_party/WebKit/Source/platform/scheduler/base/task_queue_selector.cc View 2 chunks +9 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/work_queue_sets.h View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/work_queue_sets.cc View 4 chunks +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/work_queue_sets_unittest.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (11 generated)
Sami
lgtm.
3 years, 11 months ago (2017-01-18 18:19:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642823003/20001
3 years, 11 months ago (2017-01-18 21:30:47 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 21:38:56 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/04142ad87c05fdebba5b231f274e...

Powered by Google App Engine
This is Rietveld 408576698