Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2642813002: [ObjC ARC] Converts ios/chrome/browser/suggestions:suggestions to ARC. (Closed)

Created:
3 years, 11 months ago by stkhapugin
Modified:
3 years, 11 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/suggestions:suggestions to ARC. Automatically generated ARCMigrate commit Notable issues: * Had to keep scoped_nsobject in image_fetcher_impl.mm for simplicity. BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2642813002 Cr-Commit-Position: refs/heads/master@{#444431} Committed: https://chromium.googlesource.com/chromium/src/+/7031a828c5dcedc937bbf375c42daab08ca6162f

Patch Set 1 #

Patch Set 2 : revert translate_controller #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
M ios/chrome/browser/suggestions/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/suggestions/image_fetcher_impl.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/suggestions/ios_image_decoder_impl.mm View 5 chunks +12 lines, -8 lines 0 comments Download
M ios/chrome/browser/suggestions/suggestions_service_factory.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
stkhapugin
PTAL
3 years, 11 months ago (2017-01-18 15:39:57 UTC) #4
noyau (Ping after 24h)
This was not "automatically converted", there was quite a bit of manual wrangling... Please fix ...
3 years, 11 months ago (2017-01-18 15:44:06 UTC) #5
noyau (Ping after 24h)
On 2017/01/18 15:44:06, noyau wrote: > This was not "automatically converted", there was quite a ...
3 years, 11 months ago (2017-01-18 16:10:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642813002/20001
3 years, 11 months ago (2017-01-18 17:46:06 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 19:04:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7031a828c5dcedc937bbf375c42d...

Powered by Google App Engine
This is Rietveld 408576698