Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2642783009: Rename the VR pop-up URL indicator, making way for a real omnibox (Closed)

Created:
3 years, 11 months ago by cjgrant
Modified:
3 years, 11 months ago
Reviewers:
mthiesse
CC:
chromium-reviews, feature-vr-reviews_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename the VR pop-up URL indicator, making way for a real omnibox What started out as the omnibox is not going to be the omnibox. BUG=641508 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2642783009 Cr-Commit-Position: refs/heads/master@{#445089} Committed: https://chromium.googlesource.com/chromium/src/+/094aaa164f434475b0d16f03677a0fe965497ba2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -42 lines) Patch
M chrome/browser/resources/vr_shell/vr_shell_ui.css View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/resources/vr_shell/vr_shell_ui.html View 1 chunk +8 lines, -7 lines 0 comments Download
M chrome/browser/resources/vr_shell/vr_shell_ui.js View 9 chunks +26 lines, -25 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
cjgrant
3 years, 11 months ago (2017-01-19 23:06:49 UTC) #3
mthiesse
lgtm
3 years, 11 months ago (2017-01-20 15:17:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642783009/1
3 years, 11 months ago (2017-01-20 16:38:27 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 18:10:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/094aaa164f434475b0d16f03677a...

Powered by Google App Engine
This is Rietveld 408576698