Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2642783002: Set that Active Directory users can't sync images (Closed)

Created:
3 years, 11 months ago by Roman Sorokin (ftl)
Modified:
3 years, 11 months ago
Reviewers:
xiyuan
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set that Active Directory users can't sync images Also disable oauth token fetch BUG=677509 TEST=manual Review-Url: https://codereview.chromium.org/2642783002 Cr-Commit-Position: refs/heads/master@{#444506} Committed: https://chromium.googlesource.com/chromium/src/+/bd39285aa28687c03e726e2b08d50c258d16c088

Patch Set 1 #

Patch Set 2 : Also disable oauth token fetch #

Total comments: 2

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M components/user_manager/user.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Roman Sorokin (ftl)
Hey Alex, PTAL. Thanks!
3 years, 11 months ago (2017-01-18 14:47:45 UTC) #2
Roman Sorokin (ftl)
Hey Xiyuan, could you PTAL? Thanks!
3 years, 11 months ago (2017-01-18 17:46:24 UTC) #10
xiyuan
lgtm https://codereview.chromium.org/2642783002/diff/20001/chrome/browser/chromeos/login/session/user_session_manager.cc File chrome/browser/chromeos/login/session/user_session_manager.cc (right): https://codereview.chromium.org/2642783002/diff/20001/chrome/browser/chromeos/login/session/user_session_manager.cc#newcode1120 chrome/browser/chromeos/login/session/user_session_manager.cc:1120: base::ThreadTaskRunnerHandle::Get()->PostTask( nit: Could you add a comment e.g. ...
3 years, 11 months ago (2017-01-18 17:54:28 UTC) #11
Roman Sorokin (ftl)
https://codereview.chromium.org/2642783002/diff/20001/chrome/browser/chromeos/login/session/user_session_manager.cc File chrome/browser/chromeos/login/session/user_session_manager.cc (right): https://codereview.chromium.org/2642783002/diff/20001/chrome/browser/chromeos/login/session/user_session_manager.cc#newcode1120 chrome/browser/chromeos/login/session/user_session_manager.cc:1120: base::ThreadTaskRunnerHandle::Get()->PostTask( On 2017/01/18 17:54:28, xiyuan wrote: > nit: Could ...
3 years, 11 months ago (2017-01-18 21:34:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642783002/40001
3 years, 11 months ago (2017-01-18 21:35:33 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 22:10:32 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bd39285aa28687c03e726e2b08d5...

Powered by Google App Engine
This is Rietveld 408576698