Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2642763006: Substitute for type parameters in getReifiedType. (Closed)

Created:
3 years, 11 months ago by Leaf
Modified:
3 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Substitute for type parameters in getReifiedType. The getReifiedType method for members was not correctly substituting for the type parameters of the defining type. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/6172530a91f1ac09d995a2af36249eeeb8b997a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
M pkg/analyzer/lib/src/dart/element/member.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/element/element_test.dart View 2 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Leaf
3 years, 11 months ago (2017-01-19 05:47:21 UTC) #2
Bob Nystrom
lgtm
3 years, 11 months ago (2017-01-19 17:53:49 UTC) #3
Leaf
3 years, 11 months ago (2017-01-19 20:15:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6172530a91f1ac09d995a2af36249eeeb8b997a0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698