Remove chrome/browser/ui/media_utils.{cc|h}

Remove chrome/browser/ui/media_utils.{cc|h}

This file contains a couple of global functions that can be inlined
in chrome::Browser.

This is the first step towards a better organization of the media-devices code in chrome/browser/ui.

BUG=682255
Review-Url: https://codereview.chromium.org/2642763003
Cr-Commit-Position: refs/heads/master@{#445704}
Committed: https://chromium.googlesource.com/chromium/src/+/6aace7622d23d02b6865b30a7b4a8e83d488a0d6

[Guido Urdaneta, 2017-01-18 15:45:51]

guidou@chromium.org changed reviewers:
+ pkasting@chromium.org

[Guido Urdaneta, 2017-01-18 15:45:52]

Hi, PTAL

[Peter Kasting, 2017-01-24 00:26:42]

LGTM

https://codereview.chromium.org/2642763003/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/2642763003/diff/1/chrome/browser/ui/browser.c...
chrome/browser/ui/browser.cc:264: #if BUILDFLAG(ENABLE_EXTENSIONS)
Nit: If you do this instead:

const extensions::Extension* GetExtensionForOrigin(
    Profile* profile,
    const GURL& security_origin) {
#if BUILDFLAG(ENABLE_EXTENSIONS)
  ...
#else
  return nullptr;
#endif;
}

...then callers can just drop all their #ifdefs.

https://codereview.chromium.org/2642763003/diff/1/chrome/browser/ui/browser.c...
chrome/browser/ui/browser.cc:269: return NULL;
Nit: nullptr

https://codereview.chromium.org/2642763003/diff/1/chrome/browser/ui/browser.c...
chrome/browser/ui/browser.cc:1833: const extensions::Extension* extension =
NULL;
Nit: Can be combined with the next line if you follow my suggestion above about
#ifs.

https://codereview.chromium.org/2642763003/diff/1/chrome/browser/ui/browser.c...
chrome/browser/ui/browser.cc:1855: ->CheckMediaAccessPermission(web_contents,
security_origin, type);
Nit: Since the four-arg version of CheckMediaAccessPermission() just calls the
five-arg version with nullptr, you can just do:

  return MediaCaptureDevicesDispatcher::GetInstance()
      ->CheckMediaAccessPermission(web_contents, security_origin, type,
                                   extension);

[Guido Urdaneta, 2017-01-24 10:45:39]

https://codereview.chromium.org/2642763003/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/2642763003/diff/1/chrome/browser/ui/browser.c...
chrome/browser/ui/browser.cc:264: #if BUILDFLAG(ENABLE_EXTENSIONS)
On 2017/01/24 00:26:41, Peter Kasting wrote:
> Nit: If you do this instead:
> 
> const extensions::Extension* GetExtensionForOrigin(
>     Profile* profile,
>     const GURL& security_origin) {
> #if BUILDFLAG(ENABLE_EXTENSIONS)
>   ...
> #else
>   return nullptr;
> #endif;
> }
> 
> ...then callers can just drop all their #ifdefs.

Done.

https://codereview.chromium.org/2642763003/diff/1/chrome/browser/ui/browser.c...
chrome/browser/ui/browser.cc:269: return NULL;
On 2017/01/24 00:26:42, Peter Kasting wrote:
> Nit: nullptr

Done.

https://codereview.chromium.org/2642763003/diff/1/chrome/browser/ui/browser.c...
chrome/browser/ui/browser.cc:1833: const extensions::Extension* extension =
NULL;
On 2017/01/24 00:26:41, Peter Kasting wrote:
> Nit: Can be combined with the next line if you follow my suggestion above
about
> #ifs.

Done.

https://codereview.chromium.org/2642763003/diff/1/chrome/browser/ui/browser.c...
chrome/browser/ui/browser.cc:1855: ->CheckMediaAccessPermission(web_contents,
security_origin, type);
On 2017/01/24 00:26:41, Peter Kasting wrote:
> Nit: Since the four-arg version of CheckMediaAccessPermission() just calls the
> five-arg version with nullptr, you can just do:
> 
>   return MediaCaptureDevicesDispatcher::GetInstance()
>       ->CheckMediaAccessPermission(web_contents, security_origin, type,
>                                    extension);

Done.

[Guido Urdaneta, 2017-01-24 10:45:44]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2017-01-24 10:45:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2642763003/#ps20001
(title: "rebase and address review comments")

[commit-bot: I haz the power, 2017-01-24 10:46:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 11:56:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485254744180780,
"parent_rev": "24cb6f65cb5715558f4f33ab2076e59326b661d7", "commit_rev":
"6aace7622d23d02b6865b30a7b4a8e83d488a0d6"}

[commit-bot: I haz the power, 2017-01-24 11:56:38]

Description was changed from

==========
Remove chrome/browser/ui/media_utils.{cc|h}

This file contains a couple of global functions that can be inlined
in chrome::Browser.

This is the first step towards a better organization of the media-devices code
in chrome/browser/ui.

BUG=682255
==========

to

==========
Remove chrome/browser/ui/media_utils.{cc|h}

This file contains a couple of global functions that can be inlined
in chrome::Browser.

This is the first step towards a better organization of the media-devices code
in chrome/browser/ui.

BUG=682255

Review-Url: https://codereview.chromium.org/2642763003
Cr-Commit-Position: refs/heads/master@{#445704}
Committed:
https://chromium.googlesource.com/chromium/src/+/6aace7622d23d02b6865b30a7b4a...
==========

[commit-bot: I haz the power, 2017-01-24 11:56:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6aace7622d23d02b6865b30a7b4a...