ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm - Issue 2642763002: Add UserAction when the user opens ReadingList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

Issue 2642763002: Add UserAction when the user opens ReadingList (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

diff --git a/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm b/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

index 837a52b49da0ce02ee6233895c4235232ac5df1c..9a5a274edb3d576c2e3a160ad851d3a8fc5edd5f 100644

--- a/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

+++ b/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

@@ -222,7 +222,7 @@ NS_INLINE UIEdgeInsets TabHistoryPopupMenuInsets() {

// Do nothing when tapping the tools menu a second time.

break;

case IDC_SHOW_READING_LIST:

- // TODO(crbug.com/582957): Add metric here.

+ base::RecordAction(UserMetricsAction("MobileMenuReadingList"));

break;

default:

NOTREACHED();

« no previous file with comments | « no previous file | tools/metrics/actions/actions.xml » ('j') | no next file with comments »