Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Side by Side Diff: ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

Issue 2642763002: Add UserAction when the user opens ReadingList (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/metrics/actions/actions.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/ui/tools_menu/tools_popup_controller.h" 5 #import "ios/chrome/browser/ui/tools_menu/tools_popup_controller.h"
6 6
7 #import <QuartzCore/QuartzCore.h> 7 #import <QuartzCore/QuartzCore.h>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/mac/scoped_nsobject.h" 10 #include "base/mac/scoped_nsobject.h"
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 self.containerView.hidden = YES; 215 self.containerView.hidden = YES;
216 base::RecordAction(UserMetricsAction("MobileMenuReportAnIssue")); 216 base::RecordAction(UserMetricsAction("MobileMenuReportAnIssue"));
217 break; 217 break;
218 case IDC_VIEW_SOURCE: 218 case IDC_VIEW_SOURCE:
219 // Debug only; no metric. 219 // Debug only; no metric.
220 break; 220 break;
221 case IDC_SHOW_TOOLS_MENU: 221 case IDC_SHOW_TOOLS_MENU:
222 // Do nothing when tapping the tools menu a second time. 222 // Do nothing when tapping the tools menu a second time.
223 break; 223 break;
224 case IDC_SHOW_READING_LIST: 224 case IDC_SHOW_READING_LIST:
225 // TODO(crbug.com/582957): Add metric here. 225 base::RecordAction(UserMetricsAction("MobileMenuReadingList"));
226 break; 226 break;
227 default: 227 default:
228 NOTREACHED(); 228 NOTREACHED();
229 break; 229 break;
230 } 230 }
231 231
232 // Close the menu. 232 // Close the menu.
233 [self.delegate dismissPopupMenu:self]; 233 [self.delegate dismissPopupMenu:self];
234 } 234 }
235 235
236 @end 236 @end
OLDNEW
« no previous file with comments | « no previous file | tools/metrics/actions/actions.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698