Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2642743008: [api] Mark functions related to object grouping as DEPRECATED (Closed)

Created:
3 years, 11 months ago by Michael Lippautz
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Mark functions related to object grouping as DEPRECATED Embedders should use the new EmbedderHeapTracer api. BUG=v8:5828 Review-Url: https://codereview.chromium.org/2642743008 Cr-Commit-Position: refs/heads/master@{#42974} Committed: https://chromium.googlesource.com/v8/v8/+/9e248dde60ebe3af279746395c144b529cf5bf84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M include/v8.h View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Michael Lippautz
branch cut happened
3 years, 11 months ago (2017-01-19 15:48:17 UTC) #3
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-19 17:28:54 UTC) #8
Michael Lippautz
On 2017/01/19 17:28:54, jochen (at summit until 19th) wrote: > lgtm Ah, blink compiles the ...
3 years, 11 months ago (2017-01-19 18:41:52 UTC) #9
Michael Lippautz
On 2017/01/19 18:41:52, Michael Lippautz (slow travel) wrote: > On 2017/01/19 17:28:54, jochen (at summit ...
3 years, 10 months ago (2017-02-06 17:15:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642743008/1
3 years, 10 months ago (2017-02-06 17:15:17 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 17:42:20 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9e248dde60ebe3af279746395c144b529cf...

Powered by Google App Engine
This is Rietveld 408576698