Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2642743003: [turbofan] Also recognize 'type' === typeof x. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Also recognize 'type' === typeof x. So far we only recognized typeof x == 'type' typeof x != 'type' typeof x === 'type' typeof x !== 'type' but some people seem to prefer it the other way around, i.e. 'type' == typeof x 'type' != typeof x 'type' === typeof x 'type' !== typeof x as spotted in some Ember.js code, so we should obviously handle that as well and reduce it to a quick check on x instead of calling the TypeOf builtin and comparing the resulting string. R=ishell@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2642743003 Cr-Commit-Position: refs/heads/master@{#42478} Committed: https://chromium.googlesource.com/v8/v8/+/ff46966d2d1eeac7289f6b72669f34826e40bd66

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -33 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +40 lines, -33 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-18 18:38:19 UTC) #1
Igor Sheludko
lgtm
3 years, 11 months ago (2017-01-18 20:15:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642743003/1
3 years, 11 months ago (2017-01-18 20:16:05 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 20:18:27 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ff46966d2d1eeac7289f6b72669f34826e4...

Powered by Google App Engine
This is Rietveld 408576698