Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 2642723007: chromeos: Removed enable magnifier from palette delegate. (Closed)

Created:
3 years, 11 months ago by sammiequon
Modified:
3 years, 11 months ago
Reviewers:
James Cook, jdufault
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Removed enable magnifier from palette delegate. Instead of delegating this call via //ash/common -> //chrome -> //ash, go direct from //ash/common -> //ash. BUG=647031 TEST=none Review-Url: https://codereview.chromium.org/2642723007 Cr-Commit-Position: refs/heads/master@{#446070} Committed: https://chromium.googlesource.com/chromium/src/+/238ae7416733aa814efc0218eb627a185953f825

Patch Set 1 #

Patch Set 2 : Fix try bots. #

Patch Set 3 : Trybot. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -24 lines) Patch
M ash/aura/wm_shell_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/aura/wm_shell_aura.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/common/palette_delegate.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/common/system/chromeos/palette/tools/magnifier_mode.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/test/test_palette_delegate.h View 1 3 chunks +0 lines, -4 lines 0 comments Download
M ash/common/test/test_palette_delegate.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ash/common/wm_shell.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/palette_delegate_chromeos.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/palette_delegate_chromeos.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 27 (22 generated)
sammiequon
On 2017/01/19 22:57:43, sammiequon wrote: > mailto:sammiequon@chromium.org changed reviewers: > + mailto:jamescook@chromium.org, mailto:jdufault@chromium.org jamescook@, jdufault@ ...
3 years, 11 months ago (2017-01-19 22:58:03 UTC) #20
James Cook
LGTM! Thanks for cleaning this up.
3 years, 11 months ago (2017-01-20 03:25:59 UTC) #21
jdufault
lgtm
3 years, 11 months ago (2017-01-20 18:44:12 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642723007/60001
3 years, 11 months ago (2017-01-25 17:51:48 UTC) #24
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 18:58:55 UTC) #27
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/238ae7416733aa814efc0218eb62...

Powered by Google App Engine
This is Rietveld 408576698