Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Binding.h

Issue 2642643002: Remove CallWith=ScriptState from window/self/frames getters on Window.
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8Binding.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
index 00392a53b93cb201a180f18e83c76b28d4111796..f0c0d1909b081c1f5791ed10049582790a8ff3db 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
@@ -64,6 +64,7 @@ class Frame;
class LocalDOMWindow;
class LocalFrame;
class NodeFilter;
+class WindowProxyManagerBase;
class XPathNSResolver;
template <typename T>
@@ -336,6 +337,16 @@ inline void v8SetReturnValueFast(const CallbackInfo& callbackInfo,
callbackInfo.GetIsolate()));
}
+// Special version for a DOMWindow that might be detached.
+
+template <typename CallbackInfo>
+inline void v8SetReturnValueFast(const CallbackInfo& callbackInfo,
+ WindowProxyManagerBase* impl,
+ const ScriptWrappable*) {
+ v8SetReturnValue(callbackInfo, ToV8(impl, callbackInfo.Holder(),
+ callbackInfo.GetIsolate()));
+}
+
template <typename CallbackInfo, typename T, typename Wrappable>
inline void v8SetReturnValueFast(const CallbackInfo& callbackInfo,
PassRefPtr<T> impl,

Powered by Google App Engine
This is Rietveld 408576698