Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ToV8.cpp

Issue 2642643002: Remove CallWith=ScriptState from window/self/frames getters on Window.
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ToV8.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ToV8.cpp b/third_party/WebKit/Source/bindings/core/v8/ToV8.cpp
index 42889491ff216295e7912e8a80b7e652bf8828b5..bce42d0a7923d5a332ee3b0204bfbbb33cbadc94 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ToV8.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ToV8.cpp
@@ -5,6 +5,7 @@
#include "bindings/core/v8/ToV8.h"
#include "bindings/core/v8/WindowProxy.h"
+#include "bindings/core/v8/WindowProxyManager.h"
#include "core/events/EventTarget.h"
#include "core/frame/DOMWindow.h"
#include "core/frame/Frame.h"
@@ -40,4 +41,13 @@ v8::Local<v8::Value> ToV8(EventTarget* impl,
return ToV8(static_cast<ScriptWrappable*>(impl), creationContext, isolate);
}
+v8::Local<v8::Value> ToV8(WindowProxyManagerBase* windowProxyManager,
+ v8::Local<v8::Object> creationContext,
+ v8::Isolate* isolate) {
+ // Notice that we explicitly ignore creationContext because the DOMWindow
+ // has its own creationContext.
+ return windowProxyManager->windowProxy(DOMWrapperWorld::current(isolate))
+ ->globalIfNotDetached();
Yuki 2017/01/18 07:31:43 I think globalIfNotDetached() is not equivalent to
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698