Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2642473002: Fix FilterDisplayItem::equals() (Closed)

Created:
3 years, 11 months ago by Xianzhu
Modified:
3 years, 11 months ago
Reviewers:
pdr.
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, Stephen Chennney, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, kinuko+watch, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix FilterDisplayItem::equals() - DisplayItem::equals() should be checked before casting in case that |other| is not a BeginFilterDisplayItem, to avoid bad-cast errors on asan. - Add equality checking for m_compositorFilterOperations. BUG=679717 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2642473002 Cr-Commit-Position: refs/heads/master@{#444155} Committed: https://chromium.googlesource.com/chromium/src/+/b09bc11cad3b56a0fa31387df5afae73cd95a053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Xianzhu
3 years, 11 months ago (2017-01-17 20:14:14 UTC) #6
pdr.
On 2017/01/17 at 20:14:14, wangxianzhu wrote: > LGTM
3 years, 11 months ago (2017-01-17 20:48:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642473002/1
3 years, 11 months ago (2017-01-17 21:44:33 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 21:50:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b09bc11cad3b56a0fa31387df5af...

Powered by Google App Engine
This is Rietveld 408576698