Import wpt@40665266227e475bc4a56884247d8c09d78dfb6a

Import wpt@40665266227e475bc4a56884247d8c09d78dfb6a

Using update-w3c-deps in Chromium 34fcb7fecdb23ae4a094299d78c13ff7d014d478.

This is a manual import created based on a failed auto-import (http://crrev.com/2640303004#ps20001).

The main interesting thing about this import is the addition of new tests in the streams/ and selection/ directories.

NOEXPORT=true

Review-Url: https://codereview.chromium.org/2642393002
Cr-Commit-Position: refs/heads/master@{#445180}
Committed: https://chromium.googlesource.com/chromium/src/+/ebb852019bedf0c61f2c7da67574668b84ee5efc

[qyearsley, 2017-01-20 18:23:53]

Description was changed from

==========
Import wpt@40665266227e475bc4a56884247d8c09d78dfb6a

Using update-w3c-deps in Chromium 34fcb7fecdb23ae4a094299d78c13ff7d014d478.

Build:
https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller...

patch from issue 2640303004 at patchset 20001
(http://crrev.com/2640303004#ps20001)

NOEXPORT=true
==========

to

==========
Import wpt@40665266227e475bc4a56884247d8c09d78dfb6a

Using update-w3c-deps in Chromium 34fcb7fecdb23ae4a094299d78c13ff7d014d478.

This is a manual import created based on a failed auto-import
(http://crrev.com/2640303004#ps20001).

The main interesting thing about this import is the addition of new tests in the
streams/ and selection/ directories.

NOEXPORT=true
==========

[qyearsley, 2017-01-20 18:23:53]

qyearsley@chromium.org changed reviewers:
+ domenic@chromium.org

[qyearsley, 2017-01-20 19:57:20]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 19:57:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[domenic, 2017-01-20 20:04:29]

It's unclear to me why we commit -expected.txt files instead of modifying the
test expectations file, but I'm happy these are getting imported. Although I
realize now I made some mistakes and need to change a bunch of the filenames
(.serviceworker.html shoudl be .serviceworker.https.html)

[commit-bot: I haz the power, 2017-01-20 20:59:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 20:59:58]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2017-01-20 21:29:54]

On 2017/01/20 at 20:04:29, domenic wrote:
> It's unclear to me why we commit -expected.txt files instead of modifying the
test expectations file, but I'm happy these are getting imported. Although I
realize now I made some mistakes and need to change a bunch of the filenames
(.serviceworker.html shoudl be .serviceworker.https.html)

I think that the main advantage of checking in -expected.txt files instead of
modifying TestExpectations is that then we can detect when particular sub-tests
within a test change, and we also have a record of exactly how the test behaves
in Chrome currently.

Do you think it's OK to commit this first as-is? And then when you make the
change upstream to rename the files then it should be imported?

Of course, if you'd like, you could also experiment with the export process
currently in development -- you rename the files in Chromium, and then get
jeffcarp@ to run the export script -- that might be a very nice test case :-D
But feel free to do whatever is easiest.

[domenic, 2017-01-20 21:44:14]

On 2017/01/20 at 21:29:54, qyearsley wrote:
> On 2017/01/20 at 20:04:29, domenic wrote:
> > It's unclear to me why we commit -expected.txt files instead of modifying
the test expectations file, but I'm happy these are getting imported. Although I
realize now I made some mistakes and need to change a bunch of the filenames
(.serviceworker.html shoudl be .serviceworker.https.html)
> 
> I think that the main advantage of checking in -expected.txt files instead of
modifying TestExpectations is that then we can detect when particular sub-tests
within a test change, and we also have a record of exactly how the test behaves
in Chrome currently.

Yeah, it's just that for the -expected.txt files that are giant walls of "FAIL",
I'm not sure it helps that much :).

> Do you think it's OK to commit this first as-is? And then when you make the
change upstream to rename the files then it should be imported?
> 
> Of course, if you'd like, you could also experiment with the export process
currently in development -- you rename the files in Chromium, and then get
jeffcarp@ to run the export script -- that might be a very nice test case :-D
But feel free to do whatever is easiest.

I've posted the WPT PR earlier today at
https://github.com/w3c/web-platform-tests/pull/4589; just waiting on getting it
merged. I guess my question is, what will happen when it does get merged? Will
someone have to manually rebaseline, since various files will disappear and new
ones will appear? Who would that someone be?

[qyearsley, 2017-01-20 21:45:37]

On 2017/01/20 at 21:44:14, domenic wrote:
> On 2017/01/20 at 21:29:54, qyearsley wrote:
> > On 2017/01/20 at 20:04:29, domenic wrote:
> > > It's unclear to me why we commit -expected.txt files instead of modifying
the test expectations file, but I'm happy these are getting imported. Although I
realize now I made some mistakes and need to change a bunch of the filenames
(.serviceworker.html shoudl be .serviceworker.https.html)
> > 
> > I think that the main advantage of checking in -expected.txt files instead
of modifying TestExpectations is that then we can detect when particular
sub-tests within a test change, and we also have a record of exactly how the
test behaves in Chrome currently.
> 
> Yeah, it's just that for the -expected.txt files that are giant walls of
"FAIL", I'm not sure it helps that much :).
> 
> > Do you think it's OK to commit this first as-is? And then when you make the
change upstream to rename the files then it should be imported?
> > 
> > Of course, if you'd like, you could also experiment with the export process
currently in development -- you rename the files in Chromium, and then get
jeffcarp@ to run the export script -- that might be a very nice test case :-D
But feel free to do whatever is easiest.
> 
> I've posted the WPT PR earlier today at
https://github.com/w3c/web-platform-tests/pull/4589; just waiting on getting it
merged. I guess my question is, what will happen when it does get merged? Will
someone have to manually rebaseline, since various files will disappear and new
ones will appear? Who would that someone be?

The test importer (blink-w3c-test-autoroller) should take care of it; if that
fails, then I should figure out why and fix it :-)

[domenic, 2017-01-20 21:56:41]

lgtm

[qyearsley, 2017-01-20 21:58:07]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2017-01-20 21:58:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 22:11:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484949487979840,
"parent_rev": "ddefd1bfb65586c28c94a43071f991eb2adeadce", "commit_rev":
"ebb852019bedf0c61f2c7da67574668b84ee5efc"}

[commit-bot: I haz the power, 2017-01-20 22:12:19]

Description was changed from

==========
Import wpt@40665266227e475bc4a56884247d8c09d78dfb6a

Using update-w3c-deps in Chromium 34fcb7fecdb23ae4a094299d78c13ff7d014d478.

This is a manual import created based on a failed auto-import
(http://crrev.com/2640303004#ps20001).

The main interesting thing about this import is the addition of new tests in the
streams/ and selection/ directories.

NOEXPORT=true
==========

to

==========
Import wpt@40665266227e475bc4a56884247d8c09d78dfb6a

Using update-w3c-deps in Chromium 34fcb7fecdb23ae4a094299d78c13ff7d014d478.

This is a manual import created based on a failed auto-import
(http://crrev.com/2640303004#ps20001).

The main interesting thing about this import is the addition of new tests in the
streams/ and selection/ directories.

NOEXPORT=true

Review-Url: https://codereview.chromium.org/2642393002
Cr-Commit-Position: refs/heads/master@{#445180}
Committed:
https://chromium.googlesource.com/chromium/src/+/ebb852019bedf0c61f2c7da67574...
==========

[commit-bot: I haz the power, 2017-01-20 22:12:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ebb852019bedf0c61f2c7da67574...

[pfeldman, 2017-01-21 04:32:46]

I'm seeing failed try jobs associated with the tests:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel...