Fix CHECK_OP implementation in Release builds

Fix CHECK_OP implementation in Release builds

In this particular case, we just did a (lhs)op(rhs), ignoring the case
that lhs and rhs might have different signedness.
This CL changes that to use the proper Cmp##op##Impl implementation,
which does two comparisions for signed-vs-unsigned checks, avoiding
compiler errors.

R=ishell@chromium.org

Review-Url: https://codereview.chromium.org/2642383002
Cr-Commit-Position: refs/heads/master@{#42566}
Committed: https://chromium.googlesource.com/v8/v8/+/4dcbe86e30c1ad60ed2af760b04fc21540ac2424

[Clemens Hammacher, 2017-01-20 14:03:40]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 14:03:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 14:40:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 14:40:31]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2017-01-20 14:42:47]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 14:42:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 15:21:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 15:21:10]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2017-01-20 15:25:38]

lgtm

[Clemens Hammacher, 2017-01-20 15:27:10]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2017-01-20 15:27:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 15:28:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484926030313480,
"parent_rev": "a7c06dd42a4722912381ef003cfdb2bdd5d9be4e", "commit_rev":
"4dcbe86e30c1ad60ed2af760b04fc21540ac2424"}

[commit-bot: I haz the power, 2017-01-20 15:28:59]

Description was changed from

==========
Fix CHECK_OP implementation in Release builds

In this particular case, we just did a (lhs)op(rhs), ignoring the case
that lhs and rhs might have different signedness.
This CL changes that to use the proper Cmp##op##Impl implementation,
which does two comparisions for signed-vs-unsigned checks, avoiding
compiler errors.

R=ishell@chromium.org
==========

to

==========
Fix CHECK_OP implementation in Release builds

In this particular case, we just did a (lhs)op(rhs), ignoring the case
that lhs and rhs might have different signedness.
This CL changes that to use the proper Cmp##op##Impl implementation,
which does two comparisions for signed-vs-unsigned checks, avoiding
compiler errors.

R=ishell@chromium.org

Review-Url: https://codereview.chromium.org/2642383002
Cr-Commit-Position: refs/heads/master@{#42566}
Committed:
https://chromium.googlesource.com/v8/v8/+/4dcbe86e30c1ad60ed2af760b04fc21540a...
==========

[commit-bot: I haz the power, 2017-01-20 15:29:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/4dcbe86e30c1ad60ed2af760b04fc21540a...