Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2642373003: Add TEAM/COMPONENT to OWNERS (Closed)

Created:
3 years, 11 months ago by ymzhang1
Modified:
3 years, 11 months ago
CC:
chromium-reviews, ajuma+watch-canvas_chromium.org, dshwang, jam, Justin Novosad, abarth-chromium, haraken, Rik, darin-cc_chromium.org, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add TEAM/COMPONENT information to OWNERS file BUG=679905 Review-Url: https://codereview.chromium.org/2642373003 Cr-Commit-Position: refs/heads/master@{#446387} Committed: https://chromium.googlesource.com/chromium/src/+/3e8c32bb3006e746c373356020923da18fbce6cc

Patch Set 1 #

Total comments: 4

Patch Set 2 : update TEAM/COMPO #

Patch Set 3 : Merge branch 'master' #

Patch Set 4 : update compo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M content/browser/renderer_host/OWNERS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M skia/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/imagebitmap/OWNERS View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (12 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 11 months ago (2017-01-21 01:44:51 UTC) #3
Justin Novosad
https://codereview.chromium.org/2642373003/diff/1/content/browser/renderer_host/OWNERS File content/browser/renderer_host/OWNERS (right): https://codereview.chromium.org/2642373003/diff/1/content/browser/renderer_host/OWNERS#newcode37 content/browser/renderer_host/OWNERS:37: # COMPONENT: Content>WebApps This directory is very diverse and ...
3 years, 11 months ago (2017-01-23 00:49:05 UTC) #4
ymzhang1
Thanks for the comments! Updated as suggested. https://codereview.chromium.org/2642373003/diff/1/content/browser/renderer_host/OWNERS File content/browser/renderer_host/OWNERS (right): https://codereview.chromium.org/2642373003/diff/1/content/browser/renderer_host/OWNERS#newcode37 content/browser/renderer_host/OWNERS:37: # COMPONENT: ...
3 years, 11 months ago (2017-01-24 17:26:23 UTC) #5
Justin Novosad
lgtm
3 years, 11 months ago (2017-01-24 21:08:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642373003/20001
3 years, 11 months ago (2017-01-24 21:12:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/349103)
3 years, 11 months ago (2017-01-24 21:23:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642373003/40001
3 years, 11 months ago (2017-01-25 22:00:04 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/350349)
3 years, 11 months ago (2017-01-25 22:11:14 UTC) #15
ymzhang1
asvitkine@chromium.org: Please review changes in # COMPONENT in content/browser/renderer_host/OWNER. We need a LGTM to add ...
3 years, 11 months ago (2017-01-25 22:19:20 UTC) #17
Alexei Svitkine (slow)
I don't think SiteIsolation is the right component for this. I looked at the list ...
3 years, 11 months ago (2017-01-26 16:29:19 UTC) #18
ymzhang1
On 2017/01/26 16:29:19, Alexei Svitkine (slow) wrote: > I don't think SiteIsolation is the right ...
3 years, 11 months ago (2017-01-26 17:10:28 UTC) #19
ymzhang1
3 years, 11 months ago (2017-01-26 17:10:51 UTC) #20
Alexei Svitkine (slow)
lgtm
3 years, 11 months ago (2017-01-26 17:15:38 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642373003/60001
3 years, 11 months ago (2017-01-26 17:17:05 UTC) #24
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 19:25:43 UTC) #27
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3e8c32bb3006e746c37335602092...

Powered by Google App Engine
This is Rietveld 408576698