objects.h splitting: Move RegExpMatchInfo.

objects.h splitting: Move RegExpMatchInfo.

BUG=v8:5402
Review-Url: https://codereview.chromium.org/2642353002
Cr-Commit-Position: refs/heads/master@{#42552}
Committed: https://chromium.googlesource.com/v8/v8/+/7366d8954cb1bd277d3283241da2fae62b886c48

[marja, 2017-01-20 12:03:06]

marja@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[marja, 2017-01-20 12:03:07]

wdyt?

This is a minimalistic approach where I don't touch the inlined functions...

https://codereview.chromium.org/2642353002/diff/1/src/contexts.h
File src/contexts.h (right):

https://codereview.chromium.org/2642353002/diff/1/src/contexts.h#newcode10
src/contexts.h:10: #include "src/objects/regexp-match-info.h"
This is slightly weird.. but.. contexts.h needs to know that RegexpMatchInfo* is
an Object*.

[Michael Starzinger, 2017-01-20 12:18:48]

LGTM.

https://codereview.chromium.org/2642353002/diff/1/src/contexts.h
File src/contexts.h (right):

https://codereview.chromium.org/2642353002/diff/1/src/contexts.h#newcode10
src/contexts.h:10: #include "src/objects/regexp-match-info.h"
On 2017/01/20 12:03:07, marja wrote:
> This is slightly weird.. but.. contexts.h needs to know that RegexpMatchInfo*
is
> an Object*.

question: Is it really contexts.h that needs to know the inheritance or would
adding the include to contexts-inl.h suffice?

[marja, 2017-01-20 12:27:03]

thanks for review!

https://codereview.chromium.org/2642353002/diff/1/src/contexts.h
File src/contexts.h (right):

https://codereview.chromium.org/2642353002/diff/1/src/contexts.h#newcode10
src/contexts.h:10: #include "src/objects/regexp-match-info.h"
On 2017/01/20 12:18:48, Michael Starzinger wrote:
> On 2017/01/20 12:03:07, marja wrote:
> > This is slightly weird.. but.. contexts.h needs to know that
RegexpMatchInfo*
> is
> > an Object*.
> 
> question: Is it really contexts.h that needs to know the inheritance or would
> adding the include to contexts-inl.h suffice?

Ah yes, moved it to contexts-inl.h. The macro is from here but contexts-inl.h
instantiates it.

[marja, 2017-01-20 12:27:07]

The CQ bit was checked by marja@chromium.org

[marja, 2017-01-20 12:27:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2642353002/#ps20001
(title: "code review (mstarzinger@)")

[commit-bot: I haz the power, 2017-01-20 12:27:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 12:30:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 12:30:47]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/32954)

[marja, 2017-01-20 12:31:31]

marja@chromium.org changed reviewers:
+ yangguo@chromium.org

[marja, 2017-01-20 12:31:32]

yangguo, ptal (regexp)

[Yang, 2017-01-20 12:33:33]

On 2017/01/20 12:31:32, marja wrote:
> yangguo, ptal (regexp)

lgtm. nice.

[marja, 2017-01-20 12:33:48]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2017-01-20 12:33:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 13:01:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484915628724230,
"parent_rev": "09525c8f90f2bc307e080e3a1fea0b804a77d11d", "commit_rev":
"7366d8954cb1bd277d3283241da2fae62b886c48"}

[commit-bot: I haz the power, 2017-01-20 13:02:00]

Description was changed from

==========
objects.h splitting: Move RegExpMatchInfo.

BUG=v8:5402
==========

to

==========
objects.h splitting: Move RegExpMatchInfo.

BUG=v8:5402

Review-Url: https://codereview.chromium.org/2642353002
Cr-Commit-Position: refs/heads/master@{#42552}
Committed:
https://chromium.googlesource.com/v8/v8/+/7366d8954cb1bd277d3283241da2fae62b8...
==========

[commit-bot: I haz the power, 2017-01-20 13:02:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/7366d8954cb1bd277d3283241da2fae62b8...