Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2642343003: luci_config: Request content only when desired. (Closed)

Created:
3 years, 11 months ago by dnj
Modified:
3 years, 11 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

luci_config: Request content only when desired. Don't ask the config backend to load content when the user doesn't actually ask for content. BUG=chromium:682465 TEST=unit Review-Url: https://codereview.chromium.org/2642343003 Committed: https://github.com/luci/luci-go/commit/ee266e37c9d7e787fe9d9d72348136ada6287340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M luci_config/server/cfgclient/config.go View 4 chunks +7 lines, -6 lines 0 comments Download
M luci_config/server/cfgclient/config_test.go View 5 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dnj
PTAL
3 years, 11 months ago (2017-01-21 01:43:00 UTC) #2
iannucci
lgtm
3 years, 11 months ago (2017-01-21 03:35:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642343003/1
3 years, 11 months ago (2017-01-21 03:39:53 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-21 03:51:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/ee266e37c9d7e787fe9d9d72348136ada6287340

Powered by Google App Engine
This is Rietveld 408576698