Dynamically register the power broadcast receiver.

Dynamically register the power broadcast receiver.

There is no point in spinning up the Chrome process for
implicit power changes if the user is not actively using
it.

Switch to registering dynamically, also cleans up a few
things in PowerMonitor.

BUG=680765
Review-Url: https://codereview.chromium.org/2642333003
Cr-Commit-Position: refs/heads/master@{#445555}
Committed: https://chromium.googlesource.com/chromium/src/+/3ce3ab4abf8f44e6c8849ffea5ff2c0baf00ff48

[Ted C, 2017-01-20 21:19:13]

tedchoc@chromium.org changed reviewers:
+ nyquist@chromium.org

[Ted C, 2017-01-20 21:19:14]

nyquist - PTAL

[nyquist, 2017-01-23 22:42:01]

https://codereview.chromium.org/2642333003/diff/1/base/android/java/src/org/c...
File base/android/java/src/org/chromium/base/PowerMonitor.java (right):

https://codereview.chromium.org/2642333003/diff/1/base/android/java/src/org/c...
base/android/java/src/org/chromium/base/PowerMonitor.java:42: if (sInstance !=
null) return;
Since this is a public method, should we assert anything about which thread this
runs on? Maybe just assert main thread or something like that?

[Ted C, 2017-01-23 22:49:34]

https://codereview.chromium.org/2642333003/diff/1/base/android/java/src/org/c...
File base/android/java/src/org/chromium/base/PowerMonitor.java (right):

https://codereview.chromium.org/2642333003/diff/1/base/android/java/src/org/c...
base/android/java/src/org/chromium/base/PowerMonitor.java:42: if (sInstance !=
null) return;
On 2017/01/23 22:42:01, nyquist wrote:
> Since this is a public method, should we assert anything about which thread
this
> runs on? Maybe just assert main thread or something like that?

Done.

[nyquist, 2017-01-23 22:53:05]

lgtm

[Ted C, 2017-01-23 22:55:01]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2017-01-23 22:56:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 00:20:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485212101098740,
"parent_rev": "4ca25bc262eece0c27b52eefec27ffb969359144", "commit_rev":
"3ce3ab4abf8f44e6c8849ffea5ff2c0baf00ff48"}

[commit-bot: I haz the power, 2017-01-24 00:21:20]

Description was changed from

==========
Dynamically register the power broadcast receiver.

There is no point in spinning up the Chrome process for
implicit power changes if the user is not actively using
it.

Switch to registering dynamically, also cleans up a few
things in PowerMonitor.

BUG=680765
==========

to

==========
Dynamically register the power broadcast receiver.

There is no point in spinning up the Chrome process for
implicit power changes if the user is not actively using
it.

Switch to registering dynamically, also cleans up a few
things in PowerMonitor.

BUG=680765

Review-Url: https://codereview.chromium.org/2642333003
Cr-Commit-Position: refs/heads/master@{#445555}
Committed:
https://chromium.googlesource.com/chromium/src/+/3ce3ab4abf8f44e6c8849ffea5ff...
==========

[commit-bot: I haz the power, 2017-01-24 00:21:20]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3ce3ab4abf8f44e6c8849ffea5ff...