Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4464)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java

Issue 2642303002: PlzNavigate: Chrome UI changes for new methods of WebContentsObserver (Closed)
Patch Set: undo changes for error description Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java
index 55b055802f9bb7144dc836bc81fe17621c0df6ca..af28e3bc7d0191e71b7e6cb14dca252e384e5734 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java
@@ -82,6 +82,16 @@ public class UrlOverridingTest extends ChromeActivityTestCaseBase<ChromeActivity
}
@Override
+ public void onDidFinishNavigation(Tab tab, String url, boolean isInMainFrame,
+ boolean isErrorPage, boolean hasCommitted, boolean isSamePage,
+ boolean isFragmentNavigation, Integer pageTransition, int errorCode,
+ int httpStatusCode) {
+ if (errorCode != 0) {
+ mLoadFailCallback.notifyCalled();
+ }
+ }
+
+ @Override
public void onPageLoadFinished(Tab tab) {
mFinishCallback.notifyCalled();
}
@@ -92,8 +102,8 @@ public class UrlOverridingTest extends ChromeActivityTestCaseBase<ChromeActivity
}
@Override
- public void onDidFailLoad(Tab tab, boolean isProvisionalLoad, boolean isMainFrame,
- int errorCode, String description, String failingUrl) {
+ public void onDidFailLoad(Tab tab, boolean isMainFrame, int errorCode, String description,
+ String failingUrl) {
mLoadFailCallback.notifyCalled();
}

Powered by Google App Engine
This is Rietveld 408576698