Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3702)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

Issue 2642303002: PlzNavigate: Chrome UI changes for new methods of WebContentsObserver (Closed)
Patch Set: undo changes for error description Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
index 7a35c67a8ce7a90cbdfc875aec890b77f31d55d4..4a36b3dafdf56a390f6abc7cd086b2dbcd54f9ae 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
@@ -381,9 +381,17 @@ public class WebappActivity extends FullScreenActivity {
}
@Override
- public void onDidStartProvisionalLoadForFrame(
- Tab tab, boolean isMainFrame, String validatedUrl) {
- if (isMainFrame) updateUrlBar();
+ public void onDidStartNavigation(Tab tab, String url, boolean isInMainFrame,
+ boolean isSamePage, boolean isErrorPage) {
+ if (isInMainFrame && !isSamePage) updateUrlBar();
+ }
+
+ @Override
+ public void onDidFinishNavigation(Tab tab, String url, boolean isInMainFrame,
+ boolean isErrorPage, boolean hasCommitted, boolean isSamePage,
+ boolean isFragmentNavigation, Integer pageTransition, int errorCode,
+ int httpStatusCode) {
+ if (hasCommitted && isInMainFrame) updateUrlBar();
}
@Override
@@ -413,13 +421,6 @@ public class WebappActivity extends FullScreenActivity {
}
@Override
- public void onDidNavigateMainFrame(Tab tab, String url, String baseUrl,
- boolean isNavigationToDifferentPage, boolean isNavigationInPage,
- int statusCode) {
- updateUrlBar();
- }
-
- @Override
public void onDidAttachInterstitialPage(Tab tab) {
updateUrlBar();

Powered by Google App Engine
This is Rietveld 408576698