Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4968)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java

Issue 2642303002: PlzNavigate: Chrome UI changes for new methods of WebContentsObserver (Closed)
Patch Set: undo changes for error description Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java
index e35128cf3cd436e0990a3395e68b1dc44f83d9ea..b007279bbb935be5f4926c028274e2af2e513570 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java
@@ -82,29 +82,18 @@ public class EmptyTabObserver implements TabObserver {
public void onToggleFullscreenMode(Tab tab, boolean enable) { }
@Override
- public void onDidFailLoad(Tab tab, boolean isProvisionalLoad, boolean isMainFrame,
- int errorCode, String description, String failingUrl) { }
-
- @Override
- public void onDidStartProvisionalLoadForFrame(
- Tab tab, boolean isMainFrame, String validatedUrl) {}
-
- @Override
- public void onDidCommitProvisionalLoadForFrame(Tab tab, long frameId, boolean isMainFrame,
- String url, int transitionType) { }
-
- @Override
- public void onDidNavigateMainFrame(Tab tab, String url, String baseUrl,
- boolean isNavigationToDifferentPage, boolean isFragmentNavigation, int statusCode) { }
+ public void onDidFailLoad(
+ Tab tab, boolean isMainFrame, int errorCode, String description, String failingUrl) {}
@Override
public void onDidStartNavigation(
- Tab tab, String url, boolean isInMainFrame, boolean isErrorPage) {}
+ Tab tab, String url, boolean isInMainFrame, boolean isSamePage, boolean isErrorPage) {}
@Override
public void onDidFinishNavigation(Tab tab, String url, boolean isInMainFrame,
- boolean isErrorPage, boolean hasCommitted, boolean isSamePage, Integer pageTransition,
- int errorCode) {}
+ boolean isErrorPage, boolean hasCommitted, boolean isSamePage,
+ boolean isFragmentNavigation, Integer pageTransition, int errorCode,
+ int httpStatusCode) {}
@Override
public void didFirstVisuallyNonEmptyPaint(Tab tab) {}
@@ -119,9 +108,6 @@ public class EmptyTabObserver implements TabObserver {
public void onDidDetachInterstitialPage(Tab tab) { }
@Override
- public void onDidStartNavigationToPendingEntry(Tab tab, String url) { }
-
- @Override
public void onBackgroundColorChanged(Tab tab, int color) { }
@Override

Powered by Google App Engine
This is Rietveld 408576698