chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java - Issue 2642303002: PlzNavigate: Chrome UI changes for new methods of WebContentsObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

Issue 2642303002: PlzNavigate: Chrome UI changes for new methods of WebContentsObserver (Closed)

Patch Set: undo changes for error description Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

index 2c70262dc79a47445c9fdc41fbdba48eea0819a6..80b942e6e3a83806566f04b8692da1e3a20c3697 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

@@ -284,11 +284,13 @@ public class MediaSessionTabHelper implements MediaImageCallback {

}

@Override

- public void onDidNavigateMainFrame(Tab tab, String url, String baseUrl,

- boolean isNavigationToDifferentPage, boolean isFragmentNavigation, int statusCode) {

+ public void onDidFinishNavigation(Tab tab, String url, boolean isInMainFrame,

+ boolean isErrorPage, boolean hasCommitted, boolean isSamePage,

+ boolean isFragmentNavigation, Integer pageTransition, int errorCode,

+ int httpStatusCode) {

assert tab == mTab;

- if (!isNavigationToDifferentPage) return;

+ if (!hasCommitted || !isInMainFrame || isSamePage) return;

String origin = mTab.getUrl();

try {