Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2642293003: Revert "Put the close button of a notification into focus chain." (Closed)

Created:
3 years, 11 months ago by xiyuan
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2984
Project:
chromium
Visibility:
Public.

Description

Revert "Put the close button of a notification into focus chain." This reverts commit 87b724b37d6da750c2a052e88bf828bd75ab4de0 on branch 2984 to make PFQ happy. BUG=682868, 661105 TBR=yoshiki@chromium.org Review-Url: https://codereview.chromium.org/2642293003 . Cr-Commit-Position: refs/branch-heads/2984@{#5} Cr-Branched-From: a2377c097a1fa051f90f9c02d96d010073fcb701-refs/heads/master@{#443964} Committed: https://chromium.googlesource.com/chromium/src/+/740745497c95b7e3dbd9f1d5a0e7d0245b163bcc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -61 lines) Patch
M ui/arc/notification/arc_custom_notification_view.h View 3 chunks +0 lines, -3 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_view.cc View 5 chunks +28 lines, -58 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
xiyuan
3 years, 11 months ago (2017-01-20 18:44:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
740745497c95b7e3dbd9f1d5a0e7d0245b163bcc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698