Add Isolate parameter to disallow Atomics.wait

Add Isolate parameter to disallow Atomics.wait

Atomics.wait is a function which may block, which is not allowed on the
main thread. Since V8 doesn't know whether a particular isolate is the
"main thread", this CL adds an option to Isolate::CreateParams to choose
whether this function is allowed.

Review-Url: https://codereview.chromium.org/2642293002
Cr-Commit-Position: refs/heads/master@{#42611}
Committed: https://chromium.googlesource.com/v8/v8/+/6eba6b4b89db81bc359dc041c62d1277f24bb8d4

[binji, 2017-01-20 18:41:07]

Description was changed from

==========
Add Isolate parameter to allow Atomics.wait

Atomics.wait is a function which may block, which is not allowed on the
main thread. Since V8 doesn't know whether a particular isolate is the
"main thread", this CL adds an option to Isolate::CreateParams to choose
whether this function is allowed.
==========

to

==========
Add Isolate parameter to allow Atomics.wait

Atomics.wait is a function which may block, which is not allowed on the
main thread. Since V8 doesn't know whether a particular isolate is the
"main thread", this CL adds an option to Isolate::CreateParams to choose
whether this function is allowed.
==========

[binji, 2017-01-20 18:41:13]

Description was changed from

==========
Add Isolate parameter to allow Atomics.wait

Atomics.wait is a function which may block, which is not allowed on the
main thread. Since V8 doesn't know whether a particular isolate is the
"main thread", this CL adds an option to Isolate::CreateParams to choose
whether this function is allowed.
==========

to

==========
Add Isolate parameter to disallow Atomics.wait

Atomics.wait is a function which may block, which is not allowed on the
main thread. Since V8 doesn't know whether a particular isolate is the
"main thread", this CL adds an option to Isolate::CreateParams to choose
whether this function is allowed.
==========

[binji, 2017-01-20 18:41:25]

binji@chromium.org changed reviewers:
+ jochen@chromium.org

[binji, 2017-01-20 18:41:57]

ptal, not sure this is the best way to pass through. WDYT?

[jochen (gone - plz use gerrit), 2017-01-23 08:33:07]

lgtm

alternatively, if you want to control this on a per-context basis, you could
plumb it through similar to v8::Context::AllowCodeGenerationFromStrings

https://codereview.chromium.org/2642293002/diff/1/test/mjsunit/harmony/futex.js
File test/mjsunit/harmony/futex.js (right):

https://codereview.chromium.org/2642293002/diff/1/test/mjsunit/harmony/futex....
test/mjsunit/harmony/futex.js:104: % SetAllowAtomicsWait(true);
no space between % and the intrinsic name please

[binji, 2017-01-23 18:26:30]

Thanks for info about Context; Adam mentioned it as well, but we concluded that
it may not be needed for this case since primarily we just want to this call
from the main thread, which maps nicely to Blink's mainThreadIsolate.

https://codereview.chromium.org/2642293002/diff/1/test/mjsunit/harmony/futex.js
File test/mjsunit/harmony/futex.js (right):

https://codereview.chromium.org/2642293002/diff/1/test/mjsunit/harmony/futex....
test/mjsunit/harmony/futex.js:104: % SetAllowAtomicsWait(true);
On 2017/01/23 08:33:07, jochen wrote:
> no space between % and the intrinsic name please

Hm, looks like "git cl format" did this. I'll just ignore the presubmit warning
:)

[binji, 2017-01-23 18:27:05]

The CQ bit was checked by binji@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 18:27:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 18:44:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 18:44:08]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[binji, 2017-01-23 19:54:33]

The CQ bit was checked by binji@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 19:54:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 20:27:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 20:27:26]

Dry run: This issue passed the CQ dry run.

[binji, 2017-01-23 22:03:58]

The CQ bit was checked by binji@chromium.org

[binji, 2017-01-23 22:03:58]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2642293002/#ps60001
(title: "update bytecode_expectations")

[commit-bot: I haz the power, 2017-01-23 22:04:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 22:06:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485209038150820,
"parent_rev": "67244dcef1324fe790630cc51e8b4116c4916e15", "commit_rev":
"6eba6b4b89db81bc359dc041c62d1277f24bb8d4"}

[commit-bot: I haz the power, 2017-01-23 22:06:19]

Description was changed from

==========
Add Isolate parameter to disallow Atomics.wait

Atomics.wait is a function which may block, which is not allowed on the
main thread. Since V8 doesn't know whether a particular isolate is the
"main thread", this CL adds an option to Isolate::CreateParams to choose
whether this function is allowed.
==========

to

==========
Add Isolate parameter to disallow Atomics.wait

Atomics.wait is a function which may block, which is not allowed on the
main thread. Since V8 doesn't know whether a particular isolate is the
"main thread", this CL adds an option to Isolate::CreateParams to choose
whether this function is allowed.

Review-Url: https://codereview.chromium.org/2642293002
Cr-Commit-Position: refs/heads/master@{#42611}
Committed:
https://chromium.googlesource.com/v8/v8/+/6eba6b4b89db81bc359dc041c62d1277f24...
==========

[commit-bot: I haz the power, 2017-01-23 22:06:20]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/6eba6b4b89db81bc359dc041c62d1277f24...