Issue 2642283003: GN: Only use -fPIC where needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2642283003: GN: Only use -fPIC where needed (Closed)

Created:
3 years, 11 months ago by zra

Modified:
3 years, 11 months ago

Reviewers:
rmacnak, hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	build/config/compiler/BUILD.gn	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	runtime/bin/BUILD.gn	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 7 (3 generated)

zra

3 years, 11 months ago (2017-01-20 21:40:24 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
17fa9d47b20155b6dcd7a07a08e36a0dd37bd029 (presubmit successful).