Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: runtime/bin/BUILD.gn

Issue 2642283003: GN: Only use -fPIC where needed (Closed)
Patch Set: Also on Android Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/BUILD.gn
diff --git a/runtime/bin/BUILD.gn b/runtime/bin/BUILD.gn
index ee6119a13de2e48967575ecd44f52ec8428a17fd..c3140f0d76a31fff5b21c9b7677f6a0442628b11 100644
--- a/runtime/bin/BUILD.gn
+++ b/runtime/bin/BUILD.gn
@@ -821,6 +821,9 @@ shared_library("test_extension") {
# The only effect of DART_SHARED_LIB is to export the Dart API.
"DART_SHARED_LIB",
]
+ if (is_linux || is_android) {
+ cflags = [ "-fPIC" ]
+ }
if (is_win) {
libs = [ "dart.lib" ]
abs_root_out_dir = rebase_path(root_out_dir)
@@ -841,6 +844,9 @@ shared_library("sample_extension") {
# The only effect of DART_SHARED_LIB is to export the Dart API.
"DART_SHARED_LIB",
]
+ if (is_linux || is_android) {
+ cflags = [ "-fPIC" ]
+ }
if (is_win) {
libs = [ "dart.lib" ]
abs_root_out_dir = rebase_path(root_out_dir)
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698