Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 2642213002: [Presentation API] fix DCHECK failure if PresentationRequest::create() throws SecurityError (Closed)

Created:
3 years, 11 months ago by zhaobin
Modified:
3 years, 11 months ago
Reviewers:
mark a. foltz
CC:
blink-reviews, chromium-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Presentation API] fix DCHECK failure if PresentationRequest::create() throws SecurityError DCHECK failure if use exceptionState.throwDOMException() to throw SecurityError. Use throwSecurityError() instead. BUG=673942 Review-Url: https://codereview.chromium.org/2642213002 Cr-Commit-Position: refs/heads/master@{#444898} Committed: https://chromium.googlesource.com/chromium/src/+/34215edf2e52ccf0e9fd52135afd1addde2c7356

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
zhaobin
3 years, 11 months ago (2017-01-19 21:02:49 UTC) #2
mark a. foltz
lgtm
3 years, 11 months ago (2017-01-19 21:37:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642213002/1
3 years, 11 months ago (2017-01-20 00:07:53 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 00:52:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/34215edf2e52ccf0e9fd52135afd...

Powered by Google App Engine
This is Rietveld 408576698