Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issue 2642193009: Move SetMediaKeysHandler timer to frame-specific TaskRunnerTimer. (Closed)

Created:
3 years, 11 months ago by Byoungkwon Ko
Modified:
3 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com, blink-reviews, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move SetMediaKeysHandler timer to frame-specific TaskRunnerTimer. Move SetMediaKeysHandler timer m_timer to frame-specific TaskRunnerTimer. This associates it with the frame's MiscPlatformAPI timer task queue. Spec Link: https://w3c.github.io/encrypted-media/#htmlmediaelement-extensions This CL is migrating tasks/timers from a per-renderer scheduler to a per-frame scheduler: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/80dsbEEOcWY BUG=624694 Review-Url: https://codereview.chromium.org/2642193009 Cr-Commit-Position: refs/heads/master@{#448243} Committed: https://chromium.googlesource.com/chromium/src/+/753d0fd6e0a60c1f9a44215f40d98c13a4420d1f

Patch Set 1 #

Patch Set 2 : Move SetMediaKeysHandler timer to frame-specific TaskRunnerTimer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp View 1 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
Byoungkwon Ko
PTAL Haraken@
3 years, 10 months ago (2017-02-05 16:30:33 UTC) #7
haraken
LGTM
3 years, 10 months ago (2017-02-06 00:30:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642193009/20001
3 years, 10 months ago (2017-02-06 13:58:10 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 14:04:02 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/753d0fd6e0a60c1f9a44215f40d9...

Powered by Google App Engine
This is Rietveld 408576698