Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 2642183003: Populate cc element id maps for transform/effect nodes. (Closed)

Created:
3 years, 11 months ago by wkorman
Modified:
3 years, 11 months ago
Reviewers:
pdr., ajuma
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Populate cc element id maps for transform/effect nodes. Scroll nodes are being handled similarly in http://crrev.com/2638333007. BUG=674258 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2642183003 Cr-Commit-Position: refs/heads/master@{#445477} Committed: https://chromium.googlesource.com/chromium/src/+/a26a3a7b14e17d5d76b393f7df52210346b359cb

Patch Set 1 #

Patch Set 2 : Add tests and don't set element_id fields that don't exist. #

Patch Set 3 : Sync to head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp View 1 2 2 chunks +51 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp View 1 2 5 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
wkorman
I'll work on tests for this tomorrow, just sending so you can see the analogue ...
3 years, 11 months ago (2017-01-20 01:56:06 UTC) #4
wkorman
PTAL, added tests.
3 years, 11 months ago (2017-01-21 00:41:54 UTC) #6
pdr.
LGTM
3 years, 11 months ago (2017-01-23 00:58:39 UTC) #7
ajuma
lgtm too
3 years, 11 months ago (2017-01-23 14:43:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642183003/40001
3 years, 11 months ago (2017-01-23 19:08:23 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 20:50:23 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a26a3a7b14e17d5d76b393f7df52...

Powered by Google App Engine
This is Rietveld 408576698