Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2642173002:
Migrate GCMKeyStore and InkDropImpl tests to use EXPECT_DCHECK_DEATH. (Closed)
DescriptionMigrate GCMKeyStore and InkDropImpl tests to use EXPECT_DCHECK_DEATH.
Previously the GCMKeyStore tests used net/ EXPECT_DFATAL(), which avoids forking but is designed to expect LOG(DFATAL) in net/ code, rather than DCHECKs.
The InkDropImplTest used ASSERT_DEATH_IF_SUPPORTED but ran conditional on DCHECK_IS_ON(), whereas EXPECT_DCHECK_DEATH() is implicitly executed only if DCHECK_IS_ON().
BUG=596231
Review-Url: https://codereview.chromium.org/2642173002
Cr-Commit-Position: refs/heads/master@{#448022}
Committed: https://chromium.googlesource.com/chromium/src/+/a870361a9f6f66ebf3618418cd3759058c844dd1
Patch Set 1 #Patch Set 2 : Remove static_assert()s #
Dependent Patchsets: Messages
Total messages: 25 (13 generated)
Description was changed from ========== Migrate tests to EXPECT_DCHECK_DEATH BUG= ========== to ========== Migrate tests to EXPECT_DCHECK_DEATH BUG=596231 ==========
Description was changed from ========== Migrate tests to EXPECT_DCHECK_DEATH BUG=596231 ========== to ========== Migrate GCMKeyStore and InkDropImpl tests to use EXPECT_DCHECK_DEATH. Previously the GCMKeyStore tests used net/ EXPECT_DFATAL(), which avoids forking but is designed to expect LOG(DFATAL) in net/ code, rather than DCHECKs. The InkDropImplTest used ASSERT_DEATH_IF_SUPPORTED but ran conditional on DCHECK_IS_ON(), whereas EXPECT_DCHECK_DEATH() is implicitly executed only if DCHECK_IS_ON(). BUG=596231 ==========
wez@chromium.org changed reviewers: + bruthig@chromium.org, johnme@chromium.org
johnme: What was the reason for using EXPECT_DFATAL()? Is the issue that EXPECT_DEATH doesn't support Android? bruthig: PTAL InkDropImpl test change.
The CQ bit was checked by wez@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
wez@chromium.org changed reviewers: + zea@chromium.org
+zea: Nic, do you know the rationale for using EXPECT_DFATAL here? Was it basically that EXPECT_[DCHECK_]DEATH doesn't support Android?
On 2017/01/27 20:25:19, Wez wrote: > +zea: Nic, do you know the rationale for using EXPECT_DFATAL here? Was it > basically that EXPECT_[DCHECK_]DEATH doesn't support Android? fwiw, John is OOO and will be back on Monday.
lgtm, thanks! EXPECT_DCHECK_DEATH didn't yet exist when those GCMKeyStoreTest tests were written. You can't use EXPECT_DEATH when tests are multi-threaded, but that doesn't apply here. The lack of Android support is unfortunate, but not a deal-breaker for these particular tests as the underlying code should behave the same on Android.
On 2017/02/01 17:36:13, johnme wrote: > lgtm, thanks! EXPECT_DCHECK_DEATH didn't yet exist when those GCMKeyStoreTest > tests were written. You can't use EXPECT_DEATH when tests are multi-threaded, > but that doesn't apply here. The lack of Android support is unfortunate, but not > a deal-breaker for these particular tests as the underlying code should behave > the same on Android. Aha - makes sense. Thanks!
The CQ bit was checked by wez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
zea: Can haz OWNERS?
LGTM (sorry, assumed others were owners)
The CQ bit was checked by wez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486143571745840,
"parent_rev": "dde6e8dff66e9a76131efe6e1f27779ca8abc867", "commit_rev":
"a870361a9f6f66ebf3618418cd3759058c844dd1"}
Message was sent while issue was closed.
Description was changed from ========== Migrate GCMKeyStore and InkDropImpl tests to use EXPECT_DCHECK_DEATH. Previously the GCMKeyStore tests used net/ EXPECT_DFATAL(), which avoids forking but is designed to expect LOG(DFATAL) in net/ code, rather than DCHECKs. The InkDropImplTest used ASSERT_DEATH_IF_SUPPORTED but ran conditional on DCHECK_IS_ON(), whereas EXPECT_DCHECK_DEATH() is implicitly executed only if DCHECK_IS_ON(). BUG=596231 ========== to ========== Migrate GCMKeyStore and InkDropImpl tests to use EXPECT_DCHECK_DEATH. Previously the GCMKeyStore tests used net/ EXPECT_DFATAL(), which avoids forking but is designed to expect LOG(DFATAL) in net/ code, rather than DCHECKs. The InkDropImplTest used ASSERT_DEATH_IF_SUPPORTED but ran conditional on DCHECK_IS_ON(), whereas EXPECT_DCHECK_DEATH() is implicitly executed only if DCHECK_IS_ON(). BUG=596231 Review-Url: https://codereview.chromium.org/2642173002 Cr-Commit-Position: refs/heads/master@{#448022} Committed: https://chromium.googlesource.com/chromium/src/+/a870361a9f6f66ebf3618418cd37... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/a870361a9f6f66ebf3618418cd37... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
