Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2642163002: Disable console output from the test, to ignore msg diff for x-site frames. (Closed)

Created:
3 years, 11 months ago by Łukasz Anforowicz
Modified:
3 years, 11 months ago
Reviewers:
Nate Chapin
CC:
chromium-reviews, blink-reviews, alexmos, Bin Lu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable console output from the test, to ignore msg diff for x-site frames. Without OOPIFs the console message emitted during the test looks as follows: CONSOLE ERROR: line 8: Unsafe JavaScript attempt to initiate navigation for frame with URL 'http://127.0.0.1:8000/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture.html' With OOPIFs only the origin is known: CONSOLE ERROR: line 8: Unsafe JavaScript attempt to initiate navigation for frame with origin 'http://127.0.0.1:8000' ... This CL makes sure the test output is the same with and without OOPIFs, by disabling logging of console output. The validation of the main thing the test wants to test (whether top-level navigation happened or not) is still happening by verifying if the child frame stayed at its current location (which wouldn't have happened if its top-level parent was navigated) - this is verified by checking if the child frame still contains the following text: The top navigation from this iframe should be blocked. This text should appear. BUG=682726 TEST=Run the layout test with and without --site-per-process Review-Url: https://codereview.chromium.org/2642163002 Cr-Commit-Position: refs/heads/master@{#444806} Committed: https://chromium.googlesource.com/chromium/src/+/ea3bb6bbd7ff85c64dd603505ba7822dd86cff16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Łukasz Anforowicz
Nate, could you PTAL? This CL should make site isolation bots green again. See the ...
3 years, 11 months ago (2017-01-19 17:53:54 UTC) #4
Nate Chapin
lgtm
3 years, 11 months ago (2017-01-19 18:46:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642163002/1
3 years, 11 months ago (2017-01-19 18:59:50 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 19:06:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ea3bb6bbd7ff85c64dd603505ba7...

Powered by Google App Engine
This is Rietveld 408576698