Chromium Code Reviews
DescriptionDisable console output from the test, to ignore msg diff for x-site frames.
Without OOPIFs the console message emitted during the test looks as
follows:
CONSOLE ERROR: line 8: Unsafe JavaScript attempt to initiate navigation
for frame with URL
'http://127.0.0.1:8000/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture.html'
With OOPIFs only the origin is known:
CONSOLE ERROR: line 8: Unsafe JavaScript attempt to initiate navigation
for frame with origin 'http://127.0.0.1:8000' ...
This CL makes sure the test output is the same with and without OOPIFs,
by disabling logging of console output. The validation of the main
thing the test wants to test (whether top-level navigation happened
or not) is still happening by verifying if the child frame stayed
at its current location (which wouldn't have happened if its top-level
parent was navigated) - this is verified by checking if the child frame
still contains the following text:
The top navigation from this iframe should be blocked.
This text should appear.
BUG=682726
TEST=Run the layout test with and without --site-per-process
Review-Url: https://codereview.chromium.org/2642163002
Cr-Commit-Position: refs/heads/master@{#444806}
Committed: https://chromium.googlesource.com/chromium/src/+/ea3bb6bbd7ff85c64dd603505ba7822dd86cff16
Patch Set 1 #
Messages
Total messages: 12 (8 generated)
|
||||||||||||||||||||||||||||