Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2642143002: [headless] Make --hide-scrollbars affect all BrowserContexts. (Closed)

Created:
3 years, 11 months ago by Eric Seckler
Modified:
3 years, 11 months ago
Reviewers:
Sami
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[headless] Make --hide-scrollbars affect all BrowserContexts. BUG=679343 Review-Url: https://codereview.chromium.org/2642143002 Cr-Commit-Position: refs/heads/master@{#445712} Committed: https://chromium.googlesource.com/chromium/src/+/b6dc3caa93f5db4213f9e3790d469cfd841bb466

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -22 lines) Patch
M headless/app/headless_shell.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M headless/lib/browser/headless_browser_context_options.h View 1 chunk +2 lines, -1 line 0 comments Download
M headless/lib/browser/headless_browser_context_options.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M headless/public/headless_browser.h View 2 chunks +10 lines, -0 lines 0 comments Download
M headless/public/headless_browser.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M headless/public/headless_browser_context.h View 2 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Eric Seckler
Sami, PTAL :) I'm gonna postpone looking at --deterministic-fetch. Will file another bug for that.
3 years, 11 months ago (2017-01-19 16:24:42 UTC) #2
Sami
lgtm! Sorry for sitting on this for so long :P
3 years, 11 months ago (2017-01-24 12:23:32 UTC) #7
Eric Seckler
On 2017/01/24 12:23:32, Sami wrote: > lgtm! Sorry for sitting on this for so long ...
3 years, 11 months ago (2017-01-24 12:49:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642143002/1
3 years, 11 months ago (2017-01-24 12:49:46 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 13:23:44 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b6dc3caa93f5db4213f9e3790d46...

Powered by Google App Engine
This is Rietveld 408576698