Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2642133004: Do not register any flash if flash is disabled (Closed)

Created:
3 years, 11 months ago by xhwang
Modified:
3 years, 11 months ago
Reviewers:
waffles, Nico
CC:
chromium-reviews, yukuairoy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not register any flash if flash is disabled BUG=683379 Review-Url: https://codereview.chromium.org/2642133004 Cr-Commit-Position: refs/heads/master@{#445451} Committed: https://chromium.googlesource.com/chromium/src/+/d81b1c7481a410b5bc393cf6e0fb4179ca76e7eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/common/chrome_content_client.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
xhwang
waffles: PTAL yukuairoy: FYI
3 years, 11 months ago (2017-01-20 22:07:24 UTC) #4
waffles
lgtm but I am not an owner
3 years, 11 months ago (2017-01-20 22:11:13 UTC) #5
xhwang
3 years, 11 months ago (2017-01-20 22:12:25 UTC) #7
xhwang
thakis: Please chrome/ OWNERS review this trivial change!
3 years, 11 months ago (2017-01-20 22:14:46 UTC) #10
Nico
rs-lgtm
3 years, 11 months ago (2017-01-22 21:49:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642133004/1
3 years, 11 months ago (2017-01-23 17:38:33 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/353126)
3 years, 11 months ago (2017-01-23 17:40:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642133004/1
3 years, 11 months ago (2017-01-23 18:19:56 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 20:06:52 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d81b1c7481a410b5bc393cf6e0fb...

Powered by Google App Engine
This is Rietveld 408576698