|
|
Chromium Code Reviews
DescriptionDo not register any flash if flash is disabled
BUG=683379
Review-Url: https://codereview.chromium.org/2642133004
Cr-Commit-Position: refs/heads/master@{#445451}
Committed: https://chromium.googlesource.com/chromium/src/+/d81b1c7481a410b5bc393cf6e0fb4179ca76e7eb
Patch Set 1 #
Messages
Total messages: 22 (13 generated)
The CQ bit was checked by xhwang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
xhwang@chromium.org changed reviewers: + waffles@chromium.org
waffles: PTAL yukuairoy: FYI
lgtm but I am not an owner
xhwang@chromium.org changed reviewers: + bauerb@chromium.org
Description was changed from ========== Do not register any flash if flash is disabled BUG=683379 ========== to ========== Do not register any flash if flash is disabled BUG=683379 ==========
xhwang@chromium.org changed reviewers: + thakis@chromium.org - bauerb@chromium.org
thakis: Please chrome/ OWNERS review this trivial change!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rs-lgtm
The CQ bit was checked by xhwang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by xhwang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485195567836760, "parent_rev":
"720b0962e8af0fb09e108ee575d5184401598148", "commit_rev":
"d81b1c7481a410b5bc393cf6e0fb4179ca76e7eb"}
Message was sent while issue was closed.
Description was changed from ========== Do not register any flash if flash is disabled BUG=683379 ========== to ========== Do not register any flash if flash is disabled BUG=683379 Review-Url: https://codereview.chromium.org/2642133004 Cr-Commit-Position: refs/heads/master@{#445451} Committed: https://chromium.googlesource.com/chromium/src/+/d81b1c7481a410b5bc393cf6e0fb... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d81b1c7481a410b5bc393cf6e0fb... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
