chromeos: Remove OS_WIN and OS_CHROMEOS ifdefs from ash/test

chromeos: Remove OS_WIN and OS_CHROMEOS ifdefs from ash/test

Ash only compiles on Chrome OS, so there is no need for these checks anymore.

BUG=666773
TEST=compiles, ash_unittests

Review-Url: https://codereview.chromium.org/2642113004
Cr-Commit-Position: refs/heads/master@{#445064}
Committed: https://chromium.googlesource.com/chromium/src/+/e96488a02be8b2a1722f0194474be7e0cc63c054

[James Cook, 2017-01-20 05:09:28]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 05:09:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-01-20 05:10:50]

jamescook@chromium.org changed reviewers:
+ estade@chromium.org

[James Cook, 2017-01-20 05:10:50]

estade, please take a look.

Feel free to CQ if it looks good -- I'm OOO tomorrow.

https://codereview.chromium.org/2642113004/diff/1/ash/test/ash_test_helper.cc
File ash/test/ash_test_helper.cc (right):

https://codereview.chromium.org/2642113004/diff/1/ash/test/ash_test_helper.cc...
ash/test/ash_test_helper.cc:215: // http://crbug.com/682990
I didn't just rip this out because it's called in ~200 places in unit tests and
it's possible we would need to put it back for mustash.

[commit-bot: I haz the power, 2017-01-20 05:35:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 05:35:35]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2017-01-20 15:45:48]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-01-20 15:45:49]

lgtm

https://codereview.chromium.org/2642113004/diff/1/ash/test/ash_test_helper.cc
File ash/test/ash_test_helper.cc (right):

https://codereview.chromium.org/2642113004/diff/1/ash/test/ash_test_helper.cc...
ash/test/ash_test_helper.cc:214: // OS_CHROMEOS and OS_WIN in this comment as a
reminder to clean up.
sneaky!

[commit-bot: I haz the power, 2017-01-20 15:46:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 15:49:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484927148890520, "parent_rev":
"695d0c65669b7af00f8daec96d497519c0e0cb46", "commit_rev":
"e96488a02be8b2a1722f0194474be7e0cc63c054"}

[commit-bot: I haz the power, 2017-01-20 15:50:38]

Description was changed from

==========
chromeos: Remove OS_WIN and OS_CHROMEOS ifdefs from ash/test

Ash only compiles on Chrome OS, so there is no need for these checks anymore.

BUG=666773
TEST=compiles, ash_unittests
==========

to

==========
chromeos: Remove OS_WIN and OS_CHROMEOS ifdefs from ash/test

Ash only compiles on Chrome OS, so there is no need for these checks anymore.

BUG=666773
TEST=compiles, ash_unittests

Review-Url: https://codereview.chromium.org/2642113004
Cr-Commit-Position: refs/heads/master@{#445064}
Committed:
https://chromium.googlesource.com/chromium/src/+/e96488a02be8b2a1722f0194474b...
==========

[commit-bot: I haz the power, 2017-01-20 15:50:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e96488a02be8b2a1722f0194474b...

[James Cook, 2017-01-20 20:23:24]

Thanks for putting it in the CQ!