Implements CSSPropertyAPI for the shape-outside property.

Implements CSSPropertyAPI for the shape-outside property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyShapeOutside from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIShapeOutside.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIShapeOutside.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIShapeOutside.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012
Review-Url: https://codereview.chromium.org/2642013002
Cr-Commit-Position: refs/heads/master@{#444958}
Committed: https://chromium.googlesource.com/chromium/src/+/81764f7d4806e67c5db9b46de3cf861a43af380b

[ktyliu, 2017-01-19 01:00:13]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 01:00:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aazzam, 2017-01-19 01:48:37]

aazzam@google.com changed reviewers:
+ aazzam@google.com, sashab@chromium.org

[aazzam, 2017-01-19 01:48:38]

lgtm with comments, ptal sasha :)

https://codereview.chromium.org/2642013002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
(right):

https://codereview.chromium.org/2642013002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp:26: void
complete4Sides(CSSValue* side[4]) {
why did you put this into CSSPropertyParserHelpers instead of your utils file?
not a problem since it's generic enough (in my opinion), but just curious :)

https://codereview.chromium.org/2642013002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtil.cpp
(right):

https://codereview.chromium.org/2642013002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtil.cpp:19:
static CSSValue* consumeShapeRadius(CSSParserTokenRange& args,
put all these static helper functions into an anonymous namespace :)

[aazzam, 2017-01-19 01:50:27]

sorry kevin, could you possibly move out the logic into utils file in a separate
CL to implementing shape-outside?

Also see the bottom on my burndown doc for examples of CL descriptions, so we
can keep them all consistent :)

[commit-bot: I haz the power, 2017-01-19 02:32:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 02:32:49]

Dry run: This issue passed the CQ dry run.

[ktyliu, 2017-01-19 02:52:18]

Description was changed from

==========
Implements CSSPropertyAPI for the shape-outside property.

Added CSSPropertyShapeUtil which holds shape parsing methods.
This allows CSSPropertyShapeOutside as well as CSSPropertyClipPath to
use the consumeBasicShape method and CSSPropertyBorderRadius to use
the consumeRadii method.

BUG=668012
==========

to

==========
Added CSSPropertyShapeUtil which holds shape parsing methods.

This allows CSSPropertyShapeOutside as well as CSSPropertyClipPath to
use the consumeBasicShape method and for CSSPropertyShapeOutside and
CSSPropertyBorderRadius to use the consumeRadii method.

Moved complete4Sides into CSSPropertyParserHelpers as that method is
quite generic and simple, and used by several parser methods.

This patch:
- Adds CSSPropertyShapeUtil (.h and .cpp files) to the BUILD.gn
  file.
- Moves consumeBasicShape() and consumeRadii() from CSSPropertyParser.cpp
  to CSSPropertyShapeUtil.cpp, as well as helper methods that are put
  into anonymous namespace.
- Move complete4Sides from CSSPropertyParser.cpp to CSSPropertyParserHelpers.cpp

BUG=668012
==========

[ktyliu, 2017-01-19 04:02:58]

Description was changed from

==========
Added CSSPropertyShapeUtil which holds shape parsing methods.

This allows CSSPropertyShapeOutside as well as CSSPropertyClipPath to
use the consumeBasicShape method and for CSSPropertyShapeOutside and
CSSPropertyBorderRadius to use the consumeRadii method.

Moved complete4Sides into CSSPropertyParserHelpers as that method is
quite generic and simple, and used by several parser methods.

This patch:
- Adds CSSPropertyShapeUtil (.h and .cpp files) to the BUILD.gn
  file.
- Moves consumeBasicShape() and consumeRadii() from CSSPropertyParser.cpp
  to CSSPropertyShapeUtil.cpp, as well as helper methods that are put
  into anonymous namespace.
- Move complete4Sides from CSSPropertyParser.cpp to CSSPropertyParserHelpers.cpp

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the shape-outside property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyShapeOutside from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIShapeOutside.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIShapeOutside.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIShapeOutside.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012
==========

[ktyliu, 2017-01-19 04:02:58]

ktyliu@chromium.org changed reviewers:
- sashab@chromium.org

[ktyliu, 2017-01-19 04:04:24]

On 2017/01/19 at 01:50:27, aazzam wrote:
> sorry kevin, could you possibly move out the logic into utils file in a
separate CL to implementing shape-outside?
> 
> Also see the bottom on my burndown doc for examples of CL descriptions, so we
can keep them all consistent :)

Sure. Moved out logic into utils file in http://crrev.com/2645683003 and waiting
for Sasha's approval.

Updated CL description and will merge once 2645683003 lands

[ktyliu, 2017-01-19 23:43:03]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 23:44:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ktyliu, 2017-01-20 01:26:13]

On 2017/01/19 at 04:04:24, ktyliu wrote:
> On 2017/01/19 at 01:50:27, aazzam wrote:
> > sorry kevin, could you possibly move out the logic into utils file in a
separate CL to implementing shape-outside?
> > 
> > Also see the bottom on my burndown doc for examples of CL descriptions, so
we can keep them all consistent :)
> 
> Sure. Moved out logic into utils file in http://crrev.com/2645683003 and
waiting for Sasha's approval.
> 
> Updated CL description and will merge once 2645683003 lands

I've now merged the Utils CL.
Anna: can you please take a look and check if it's still all good, then add
Sasha?

Thanks

[commit-bot: I haz the power, 2017-01-20 01:45:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 01:45:57]

Dry run: This issue passed the CQ dry run.

[aazzam, 2017-01-20 01:54:47]

aazzam@google.com changed reviewers:
+ sashab@chromium.org

[aazzam, 2017-01-20 01:54:48]

lgtm, sasha ptal :)

[sashab, 2017-01-20 02:35:29]

LGTM! Nice work ktyliu

[ktyliu, 2017-01-20 02:36:13]

The CQ bit was checked by ktyliu@chromium.org

[commit-bot: I haz the power, 2017-01-20 02:36:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 02:41:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484879773960020,
"parent_rev": "789e376399c0241ec76917af86c0b216791b6075", "commit_rev":
"81764f7d4806e67c5db9b46de3cf861a43af380b"}

[commit-bot: I haz the power, 2017-01-20 02:41:34]

Description was changed from

==========
Implements CSSPropertyAPI for the shape-outside property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyShapeOutside from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIShapeOutside.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIShapeOutside.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIShapeOutside.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the shape-outside property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyShapeOutside from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIShapeOutside.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIShapeOutside.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIShapeOutside.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2642013002
Cr-Commit-Position: refs/heads/master@{#444958}
Committed:
https://chromium.googlesource.com/chromium/src/+/81764f7d4806e67c5db9b46de3cf...
==========

[commit-bot: I haz the power, 2017-01-20 02:41:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/81764f7d4806e67c5db9b46de3cf...