Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2641973002: Use gfx::ICCProfile type consistently (Closed)

Created:
3 years, 11 months ago by ccameron
Modified:
3 years, 11 months ago
Reviewers:
esprehn
CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, dshwang, kinuko+watch, rwlbuis, krit, drott+blinkwatch_chromium.org, jam, Justin Novosad, dglazkov+blink, Rik, darin-cc_chromium.org, blink-reviews, einbinder+watch-test-runner_chromium.org, ajuma+watch_chromium.org, blink-reviews-api_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, jbroman, pdr+graphicswatchlist_chromium.org, Stephen Chennney, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, f(malita), danakj+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use gfx::ICCProfile type consistently This is a re-landing of parts of https://codereview.chromium.org/2605743002/ To determine the reason for trybots not matching continuous bots. TBR=esprehn BUG=634102 Review-Url: https://codereview.chromium.org/2641973002 Cr-Commit-Position: refs/heads/master@{#444968} Committed: https://chromium.googlesource.com/chromium/src/+/c21ca23b30ba6df8f52de972c3098367f0fcd73e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -22 lines) Patch
M content/renderer/render_view_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M content/renderer/render_widget.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget_owner_delegate.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/test/layouttest_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ColorBehavior.h View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/ImageDecodeBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebView.h View 2 chunks +5 lines, -1 line 0 comments Download
M ui/gfx/icc_profile.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/icc_profile.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2629723006 Patch 40001

Messages

Total messages: 9 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641973002/1
3 years, 11 months ago (2017-01-20 00:41:21 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 03:34:44 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c21ca23b30ba6df8f52de972c309...

Powered by Google App Engine
This is Rietveld 408576698