Remove setting cancelBubble to false.

Remove setting cancelBubble to false.

According to spec https://dom.spec.whatwg.org/#dom-event-cancelbubble, setting
cancelBubble to true is considered as an alias to stopPropagation(), setting
cancelBubble to false is a no-op. Detail discussion is on
https://github.com/whatwg/dom/issues/211.

BUG=675549
Review-Url: https://codereview.chromium.org/2641953006
Cr-Commit-Position: refs/heads/master@{#446118}
Committed: https://chromium.googlesource.com/chromium/src/+/b461901d4922144f8cd88810a60e23a3a5d08e4c

[lpy, 2017-01-20 21:36:09]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 21:36:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 22:19:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 22:19:58]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[lpy, 2017-01-20 22:43:57]

Description was changed from

==========
Prepare to deprecate and remove setting cancelBubble to false.

According to spec https://dom.spec.whatwg.org/#dom-event-cancelbubble, setting
cancelBubble to true is considered as an alias to stopPropagation(), setting
cancelBubble to false is a no-op. Detail discussion is on
https://github.com/whatwg/dom/issues/211.

BUG=675549
==========

to

==========
Deprecate and prepare to remove setting cancelBubble to false.

According to spec https://dom.spec.whatwg.org/#dom-event-cancelbubble, setting
cancelBubble to true is considered as an alias to stopPropagation(), setting
cancelBubble to false is a no-op. Detail discussion is on
https://github.com/whatwg/dom/issues/211.

BUG=675549
==========

[lpy, 2017-01-22 23:32:17]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-22 23:32:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 00:08:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 00:08:16]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[lpy, 2017-01-23 19:33:31]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 19:34:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 21:31:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 21:31:28]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lpy, 2017-01-23 23:27:25]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[lpy, 2017-01-23 23:27:44]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-01-23 23:28:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpy, 2017-01-24 01:00:48]

lpy@chromium.org changed reviewers:
+ foolip@chromium.org, hayato@chromium.org

[lpy, 2017-01-24 01:00:49]

PTAL.

[lpy, 2017-01-24 01:01:25]

lpy@chromium.org changed reviewers:
+ rbyers@chromium.org

[commit-bot: I haz the power, 2017-01-24 03:19:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 03:19:35]

Dry run: This issue passed the CQ dry run.

[hayato, 2017-01-24 04:15:14]

lgtm

[foolip, 2017-01-24 04:34:12]

lgtm % deprecation message

https://codereview.chromium.org/2641953006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2641953006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/Deprecation.cpp:411: return
willBeRemoved("Setting cancelBubble to false", M59,
I think this will be misleading, because the change will have already been made.
In
https://groups.google.com/a/chromium.org/d/msg/blink-dev/GO7hv2yuhqM/jFy1WoR5...
rbyers@ was fine with skipping the deprecation period and that seems OK I think.

[lpy, 2017-01-24 21:44:48]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 21:45:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpy, 2017-01-24 21:46:04]

lpy@chromium.org changed reviewers:
+ haraken@chromium.org, jsbell@chromium.org, ojan@chromium.org

[lpy, 2017-01-24 21:46:05]

Thanks, I remove the deprecation message.

+jsbell@ for IDB
+ojan@ for LayoutTests
+haraken@ for histogram

https://codereview.chromium.org/2641953006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2641953006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/Deprecation.cpp:411: return
willBeRemoved("Setting cancelBubble to false", M59,
On 2017/01/24 04:34:11, foolip_UTC7 wrote:
> I think this will be misleading, because the change will have already been
made.
> In
>
https://groups.google.com/a/chromium.org/d/msg/blink-dev/GO7hv2yuhqM/jFy1WoR5...
> rbyers@ was fine with skipping the deprecation period and that seems OK I
think.

Done.

[haraken, 2017-01-24 21:47:03]

histograms LGTM

[lpy, 2017-01-24 22:34:03]

Description was changed from

==========
Deprecate and prepare to remove setting cancelBubble to false.

According to spec https://dom.spec.whatwg.org/#dom-event-cancelbubble, setting
cancelBubble to true is considered as an alias to stopPropagation(), setting
cancelBubble to false is a no-op. Detail discussion is on
https://github.com/whatwg/dom/issues/211.

BUG=675549
==========

to

==========
Deprecate and remove setting cancelBubble to false.

According to spec https://dom.spec.whatwg.org/#dom-event-cancelbubble, setting
cancelBubble to true is considered as an alias to stopPropagation(), setting
cancelBubble to false is a no-op. Detail discussion is on
https://github.com/whatwg/dom/issues/211.

BUG=675549
==========

[commit-bot: I haz the power, 2017-01-24 23:50:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 23:50:31]

Dry run: This issue passed the CQ dry run.

[foolip, 2017-01-25 06:19:55]

On 2017/01/24 21:46:05, lpy wrote:
> Thanks, I remove the deprecation message.

Great, thanks! Can you also update the title+description to say just "remove"?

[lpy, 2017-01-25 06:20:43]

Description was changed from

==========
Deprecate and remove setting cancelBubble to false.

According to spec https://dom.spec.whatwg.org/#dom-event-cancelbubble, setting
cancelBubble to true is considered as an alias to stopPropagation(), setting
cancelBubble to false is a no-op. Detail discussion is on
https://github.com/whatwg/dom/issues/211.

BUG=675549
==========

to

==========
Remove setting cancelBubble to false.

According to spec https://dom.spec.whatwg.org/#dom-event-cancelbubble, setting
cancelBubble to true is considered as an alias to stopPropagation(), setting
cancelBubble to false is a no-op. Detail discussion is on
https://github.com/whatwg/dom/issues/211.

BUG=675549
==========

[lpy, 2017-01-25 06:20:55]

On 2017/01/25 06:19:55, foolip_UTC7 wrote:
> On 2017/01/24 21:46:05, lpy wrote:
> > Thanks, I remove the deprecation message.
> 
> Great, thanks! Can you also update the title+description to say just "remove"?

Done.

[lpy, 2017-01-25 21:06:46]

The CQ bit was checked by lpy@chromium.org

[lpy, 2017-01-25 21:06:47]

The patchset sent to the CQ was uploaded after l-g-t-m from hayato@chromium.org,
foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2641953006/#ps60001
(title: "Remove deprecation message")

[commit-bot: I haz the power, 2017-01-25 21:07:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 21:13:05]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485378406949630,
"parent_rev": "76a10b17535c0456f042817a69fa036f226b26a3", "commit_rev":
"b461901d4922144f8cd88810a60e23a3a5d08e4c"}

[commit-bot: I haz the power, 2017-01-25 21:14:09]

Description was changed from

==========
Remove setting cancelBubble to false.

According to spec https://dom.spec.whatwg.org/#dom-event-cancelbubble, setting
cancelBubble to true is considered as an alias to stopPropagation(), setting
cancelBubble to false is a no-op. Detail discussion is on
https://github.com/whatwg/dom/issues/211.

BUG=675549
==========

to

==========
Remove setting cancelBubble to false.

According to spec https://dom.spec.whatwg.org/#dom-event-cancelbubble, setting
cancelBubble to true is considered as an alias to stopPropagation(), setting
cancelBubble to false is a no-op. Detail discussion is on
https://github.com/whatwg/dom/issues/211.

BUG=675549

Review-Url: https://codereview.chromium.org/2641953006
Cr-Commit-Position: refs/heads/master@{#446118}
Committed:
https://chromium.googlesource.com/chromium/src/+/b461901d4922144f8cd88810a60e...
==========

[commit-bot: I haz the power, 2017-01-25 21:14:13]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b461901d4922144f8cd88810a60e...