Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2641953005: ShapeDetection: LayoutTests correction: s/imported/external/ (Closed)

Created:
3 years, 11 months ago by mcasas
Modified:
3 years, 11 months ago
Reviewers:
xianglu
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ShapeDetection: LayoutTests correction: s/imported/external/ s/imported/external/ for LayoutTest resources, which were displaced in https://crrev.com/2627213003. In the code, s/isZero()/isEmpty()/ the former compares both dimensions to 0 whereas the latter compares any dimension to zero, which is what we want. BUG=682105 Review-Url: https://codereview.chromium.org/2641953005 Cr-Commit-Position: refs/heads/master@{#444932} Committed: https://chromium.googlesource.com/chromium/src/+/5fd58b97f3aaaa23c1dd4e36a63b8c1fbb41d1b9

Patch Set 1 : #

Patch Set 2 : Removed strange third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement-expected.t… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -17 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-security-test.html View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
mcasas
xianglu@ PTAL
3 years, 11 months ago (2017-01-19 22:15:07 UTC) #8
xianglu
LGTM
3 years, 11 months ago (2017-01-19 22:28:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641953005/40001
3 years, 11 months ago (2017-01-19 22:35:36 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/367330)
3 years, 11 months ago (2017-01-19 23:41:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641953005/60001
3 years, 11 months ago (2017-01-19 23:56:27 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 01:45:07 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5fd58b97f3aaaa23c1dd4e36a63b...

Powered by Google App Engine
This is Rietveld 408576698