VR Shell does not redirect to another app while in VR mode.

VR Shell does not redirect to another app while in VR mode.

- VrShellImpl sets a custom TabRedirectHandler implementation to the tab displaying the vr shell.
- The custom TabRedirectHandler implementation prevents any redirect to another app, e.g. when clicking on youtube.com.

BUG=670128
Review-Url: https://codereview.chromium.org/2641933002
Cr-Commit-Position: refs/heads/master@{#444814}
Committed: https://chromium.googlesource.com/chromium/src/+/1f9c06b2bc825d86db2fbc2b21dc35fd453f8b69

[mthiesse, 2017-01-18 18:47:21]

Description was changed from

==========
Hoverboard does not redirect to another app while in VR mode.

- Added a flag to the Tab class, which is set when in VR mode.
- When flag is set Hoverboard will not redirect to another app when you click on
links, e.g. youtube.com.

BUG=670128
==========

to

==========
Hoverboard does not redirect to another app while in VR mode.

- Added a flag to the Tab class, which is set when in VR mode.
- When flag is set Hoverboard will not redirect to another app when you click on
links, e.g. youtube.com.

BUG=670128
==========

[mthiesse, 2017-01-18 18:47:21]

mthiesse@chromium.org changed reviewers:
+ mthiesse@chromium.org

[mthiesse, 2017-01-18 19:07:52]

https://codereview.chromium.org/2641933002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/TabRedirectHandler.java
(right):

https://codereview.chromium.org/2641933002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabRedirectHandler.java:128:
public void setIsInVr(boolean isInVr) {
We're really trying to minimize how much of the rest of chrome needs to know
about whether or not we're in VR.

Would it be sufficient to have Tab#getTabRedirectHandler() return a redirect
handler that we extend for VR?

We'd need a VrTabRedirectHandler that overrides shouldStayInChrome to always
return true, and we'd need a method like Tab#setRedirectHandler(), but this
would mean the tab and redirect handler don't need to know we're in VR.

[tiborg1, 2017-01-18 19:32:24]

Description was changed from

==========
Hoverboard does not redirect to another app while in VR mode.

- Added a flag to the Tab class, which is set when in VR mode.
- When flag is set Hoverboard will not redirect to another app when you click on
links, e.g. youtube.com.

BUG=670128
==========

to

==========
VR Shell does not redirect to another app while in VR mode.

- Added a flag to the Tab class, which is set when in VR mode.
- When flag is set VR Shell will not redirect to another app when you click on
links, e.g. youtube.com.

BUG=670128
==========

[tiborg1, 2017-01-18 19:38:53]

Description was changed from

==========
VR Shell does not redirect to another app while in VR mode.

- Added a flag to the Tab class, which is set when in VR mode.
- When flag is set VR Shell will not redirect to another app when you click on
links, e.g. youtube.com.

BUG=670128
==========

to

==========
VR Shell does not redirect to another app while in VR mode.

- Added a flag to the Tab class, which is set when in VR mode.
- When flag is set VR Shell will not redirect to another app when you click on
links, e.g. youtube.com.

BUG=670128
==========

[tiborg1, 2017-01-18 20:14:34]

Description was changed from

==========
VR Shell does not redirect to another app while in VR mode.

- Added a flag to the Tab class, which is set when in VR mode.
- When flag is set VR Shell will not redirect to another app when you click on
links, e.g. youtube.com.

BUG=670128
==========

to

==========
VR Shell does not redirect to another app while in VR mode.

- VrShellImpl sets a custom TabRedirectHandler implementation to the tab
displaying the vr shell.
- The custom TabRedirectHandler implementation prevents any redirect to another
app, e.g. when clicking on youtube.com.

BUG=670128
==========

[tiborg1, 2017-01-18 20:18:20]

On 2017/01/18 19:07:52, mthiesse wrote:
>
https://codereview.chromium.org/2641933002/diff/1/chrome/android/java/src/org...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/tab/TabRedirectHandler.java
> (right):
> 
>
https://codereview.chromium.org/2641933002/diff/1/chrome/android/java/src/org...
>
chrome/android/java/src/org/chromium/chrome/browser/tab/TabRedirectHandler.java:128:
> public void setIsInVr(boolean isInVr) {
> We're really trying to minimize how much of the rest of chrome needs to know
> about whether or not we're in VR.
> 
> Would it be sufficient to have Tab#getTabRedirectHandler() return a redirect
> handler that we extend for VR?
> 
> We'd need a VrTabRedirectHandler that overrides shouldStayInChrome to always
> return true, and we'd need a method like Tab#setRedirectHandler(), but this
> would mean the tab and redirect handler don't need to know we're in VR.

Very good points! I changed it accordingly.

[mthiesse, 2017-01-18 20:20:22]

vr_shell/ lgtm

[tiborg1, 2017-01-18 20:32:18]

tiborg@google.com changed reviewers:
+ dtrainor@chromium.org

[tiborg1, 2017-01-18 20:32:18]

dtrainor@chromium.org: Please have a look.

[tiborg1, 2017-01-18 20:32:33]

The CQ bit was checked by tiborg@google.com

[tiborg1, 2017-01-18 20:32:34]

The CQ bit was unchecked by tiborg@google.com

[David Trainor- moved to gerrit, 2017-01-19 18:41:18]

lgtm

[tiborg1, 2017-01-19 18:45:33]

The CQ bit was checked by tiborg@google.com

[tiborg1, 2017-01-19 18:45:51]

The CQ bit was unchecked by tiborg@google.com

[tiborg1, 2017-01-19 18:45:53]

The CQ bit was checked by tiborg@google.com

[commit-bot: I haz the power, 2017-01-19 18:46:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 19:23:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484851553749330,
"parent_rev": "a0f0a395c1604aadbfe97a5815044fbd245d7a11", "commit_rev":
"1f9c06b2bc825d86db2fbc2b21dc35fd453f8b69"}

[commit-bot: I haz the power, 2017-01-19 19:23:40]

Description was changed from

==========
VR Shell does not redirect to another app while in VR mode.

- VrShellImpl sets a custom TabRedirectHandler implementation to the tab
displaying the vr shell.
- The custom TabRedirectHandler implementation prevents any redirect to another
app, e.g. when clicking on youtube.com.

BUG=670128
==========

to

==========
VR Shell does not redirect to another app while in VR mode.

- VrShellImpl sets a custom TabRedirectHandler implementation to the tab
displaying the vr shell.
- The custom TabRedirectHandler implementation prevents any redirect to another
app, e.g. when clicking on youtube.com.

BUG=670128

Review-Url: https://codereview.chromium.org/2641933002
Cr-Commit-Position: refs/heads/master@{#444814}
Committed:
https://chromium.googlesource.com/chromium/src/+/1f9c06b2bc825d86db2fbc2b21dc...
==========

[commit-bot: I haz the power, 2017-01-19 19:23:41]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1f9c06b2bc825d86db2fbc2b21dc...