Chromium Code Reviews
Help | Chromium Project | Sign in
(47)

Issue 2641863003: [Extensions Bindings] Add a messaging test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by Devlin
Modified:
3 months, 1 week ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, jbroman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Add a messaging test Messaging is one of the most complicated custom bindings, using multiple hooks and files. As such, it's a good test for the bindings framework. Add a simple messaging test to the native bindings tests. BUG=653596 Review-Url: https://codereview.chromium.org/2641863003 Cr-Commit-Position: refs/heads/master@{#444610} Committed: https://chromium.googlesource.com/chromium/src/+/08bc781530a6643b532f36237d4b60d8482c3d40

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -8 lines) Patch
M chrome/browser/extensions/native_bindings_apitest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/tabs_custom_bindings.js View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/native_bindings/background.js View 3 chunks +39 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/api_test/native_bindings/content_script.js View 1 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/native_bindings/manifest.json View 1 chunk +6 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/api_test/native_bindings/messaging_test.html View 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/renderer/resources/runtime_custom_bindings.js View 2 chunks +3 lines, -2 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 13 (9 generated)
Devlin
lazyboy@, mind taking a look? jbroman@, FYI.
3 months, 1 week ago (2017-01-18 17:52:44 UTC) #7
lazyboy
lgtm
3 months, 1 week ago (2017-01-19 00:40:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641863003/20001
3 months, 1 week ago (2017-01-19 02:04:59 UTC) #10
commit-bot: I haz the power
3 months, 1 week ago (2017-01-19 02:53:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/08bc781530a6643b532f36237d4b...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46