Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2641863002: [csa] Fix the bound & used condition check for RawMachineLabel and CodeAssemblerLabel. (Closed)

Created:
3 years, 11 months ago by epertoso
Modified:
3 years, 11 months ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[csa] Fix the bound & used condition check for RawMachineLabel and CodeAssemblerLabel. CodeAssemblerLabel's destructor was not calling RawMachineLabel's destructor, because label_ is zone-allocated. RawMachineLabel's destructor contains a DCHECK that would make debugging easier. If the DCHECK is not triggered, things will go awry in the register allocation phase, making it harder to debug the issue. BUG= Review-Url: https://codereview.chromium.org/2641863002 Cr-Commit-Position: refs/heads/master@{#42461} Committed: https://chromium.googlesource.com/v8/v8/+/bc857f9dfd84c6a03ed99018dfd666ee501a8cde

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/compiler/code-assembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/code-assembler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
epertoso
3 years, 11 months ago (2017-01-18 13:44:42 UTC) #5
danno
lgtm
3 years, 11 months ago (2017-01-18 14:10:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641863002/1
3 years, 11 months ago (2017-01-18 14:37:03 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 14:39:06 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/bc857f9dfd84c6a03ed99018dfd666ee501...

Powered by Google App Engine
This is Rietveld 408576698