use unique_ptr in fpdf_font_cid.cpp

use unique_ptr in fpdf_font_cid.cpp

Also return CFX_MaybeOwned<> from functions so to make cleanup automatic,
avoiding a theoretical leak.

Review-Url: https://codereview.chromium.org/2641853004
Committed: https://pdfium.googlesource.com/pdfium/+/dd533baad22f5143c093b98e98463a0dc62899ea

[Tom Sepez, 2017-01-18 22:06:19]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 22:06:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 22:35:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 22:35:52]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2017-01-18 22:45:46]

Description was changed from

==========
use unique_ptr in fpdf_font_cid.cpp
==========

to

==========
use unique_ptr in fpdf_font_cid.cpp

Also return CFX_MaybeOwned<> from functions so to make cleanup automatic.
==========

[Tom Sepez, 2017-01-18 22:47:36]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 22:47:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2017-01-18 22:47:49]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2017-01-18 22:47:50]

Dan, for review.

[Tom Sepez, 2017-01-18 22:49:51]

Description was changed from

==========
use unique_ptr in fpdf_font_cid.cpp

Also return CFX_MaybeOwned<> from functions so to make cleanup automatic.
==========

to

==========
use unique_ptr in fpdf_font_cid.cpp

Also return CFX_MaybeOwned<> from functions so to make cleanup automatic,
avoiding a theoretical leak.
==========

[commit-bot: I haz the power, 2017-01-18 23:02:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 23:02:32]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2017-01-18 23:16:25]

https://codereview.chromium.org/2641853004/diff/20001/core/fpdfapi/font/fpdf_...
File core/fpdfapi/font/fpdf_font_cid.cpp (left):

https://codereview.chromium.org/2641853004/diff/20001/core/fpdfapi/font/fpdf_...
core/fpdfapi/font/fpdf_font_cid.cpp:300: if (!name.IsEmpty()) {
note: leak here if name is empty and we don't stick new object into map where it
will be deleted later.  Caller can't distinguish between these cases ....

[dsinclair, 2017-01-19 14:55:50]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2017-01-19 14:55:50]

lgtm

[commit-bot: I haz the power, 2017-01-19 14:55:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 14:56:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484837750336790,
"parent_rev": "e6cf01356e3336dc4f0717a391d9067693a418c1", "commit_rev":
"dd533baad22f5143c093b98e98463a0dc62899ea"}

[commit-bot: I haz the power, 2017-01-19 14:56:16]

Description was changed from

==========
use unique_ptr in fpdf_font_cid.cpp

Also return CFX_MaybeOwned<> from functions so to make cleanup automatic,
avoiding a theoretical leak.
==========

to

==========
use unique_ptr in fpdf_font_cid.cpp

Also return CFX_MaybeOwned<> from functions so to make cleanup automatic,
avoiding a theoretical leak.

Review-Url: https://codereview.chromium.org/2641853004
Committed:
https://pdfium.googlesource.com/pdfium/+/dd533baad22f5143c093b98e98463a0dc628...
==========

[commit-bot: I haz the power, 2017-01-19 14:56:17]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/dd533baad22f5143c093b98e98463a0dc628...