Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2641823002: [MIPS64] Fix tagged vs. untagged SMI comparison in Apply builtin. (Closed)

Created:
3 years, 11 months ago by petermarshall
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[MIPS64] Fix tagged vs. untagged SMI comparison in Apply builtin. This fast path check compared a tagged smi and an untagged one, meaning that the slow path was always taken. Review-Url: https://codereview.chromium.org/2641823002 Cr-Commit-Position: refs/heads/master@{#42445} Committed: https://chromium.googlesource.com/v8/v8/+/4064c41eaa0c463a067a911f6d70c0892b193394

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/builtins/mips64/builtins-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
petermarshall
PTAL =]
3 years, 11 months ago (2017-01-18 10:16:19 UTC) #5
Benedikt Meurer
lgtm
3 years, 11 months ago (2017-01-18 10:18:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641823002/1
3 years, 11 months ago (2017-01-18 10:42:14 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 10:43:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/4064c41eaa0c463a067a911f6d70c0892b1...

Powered by Google App Engine
This is Rietveld 408576698