Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2641743002: Revert the change to render thumbnail in CANVAS mode for fixing regression. (Closed)

Created:
3 years, 11 months ago by yamaguchi
Modified:
3 years, 11 months ago
Reviewers:
fukino
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the drag thumbnail rendering back to IMAGE mode to fix a regression. Here is the change that caused crbug.com/681796. This changelist partially reverts its change that affected drag thumbnail rendering. https://codereview.chromium.org/2630283002/ When an item is rendered in CANVAS mode, some metadata field are not filled unlike IMAGE mode. It causes unexpected execution path and outputs an error when clicking on a non-image file whose thumbnail is not yet cached. BUG=681796, 680420 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2641743002 Cr-Commit-Position: refs/heads/master@{#444311} Committed: https://chromium.googlesource.com/chromium/src/+/461ae5544464cdc9d3429311f553568f95da2b2a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/file_manager/file_manager/foreground/js/file_transfer_controller.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
yamaguchi
ptal
3 years, 11 months ago (2017-01-18 06:45:31 UTC) #6
fukino
lgtm
3 years, 11 months ago (2017-01-18 08:04:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641743002/1
3 years, 11 months ago (2017-01-18 09:22:33 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 09:26:24 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/461ae5544464cdc9d3429311f553...

Powered by Google App Engine
This is Rietveld 408576698