Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2641683002: Move virtual/mojo-localstorage/imported -> external. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
tkent, Rick Byers
CC:
Aaron Boodman, abarth-chromium, blink-reviews, chromium-reviews, darin (slow to review), Marijn Kruisselbrink, qsr+mojo_chromium.org, tfarina, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move virtual/mojo-localstorage/imported -> external. In http://crrev.com/2627213003, I moved the imported/ directory to external/ and made most related changes, but missed this related directory. BUG=678788 NOTRY=true Review-Url: https://codereview.chromium.org/2641683002 Cr-Commit-Position: refs/heads/master@{#444224} Committed: https://chromium.googlesource.com/chromium/src/+/d94c7b072f3b496815122c3c310456320d592c3c

Patch Set 1 #

Patch Set 2 : Move virtual/mojo-localstorage/imported -> external. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -0 lines) Patch
A + third_party/WebKit/LayoutTests/virtual/mojo-localstorage/external/wpt/webstorage/README.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/mojo-localstorage/imported/wpt/webstorage/README.txt View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (13 generated)
qyearsley
3 years, 11 months ago (2017-01-18 00:12:07 UTC) #4
tkent
lgtm
3 years, 11 months ago (2017-01-18 00:12:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641683002/20001
3 years, 11 months ago (2017-01-18 00:13:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641683002/20001
3 years, 11 months ago (2017-01-18 00:40:18 UTC) #13
tkent
Added NOTRY=true.
3 years, 11 months ago (2017-01-18 00:40:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641683002/20001
3 years, 11 months ago (2017-01-18 01:12:24 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 01:23:43 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d94c7b072f3b496815122c3c3104...

Powered by Google App Engine
This is Rietveld 408576698